refactor: bulk update for player/map ranking - #127
Merged
ahmadbky merged 2 commits intoMar 30, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the SOCC player/map ranking updater to avoid per-row SQL updates by performing chunked bulk updates, addressing Issue #125’s “queries in loop” problem.
Changes:
- Replaces per-entity updates with
update_many()+CASE WHENbulk updates (chunked to stay under bind-parameter limits). - Builds Redis
ZADDpipeline while iterating scores, then executes it after the SQL transaction. - Changes
update()to log success/error instead of propagatingdo_update()failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #125.