fix: support capital-preserving opposite-side bets - #122
Open
MJ-RWA wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
OppositeSideBetlimitation that permanently locks users to the side of a prediction market they initially selected.The implementation extends the existing position model to support opposite-side position changes while preserving the contract's existing economic and accounting invariants.
Problem
Previously,
place_betrejected any attempt to bet on the opposite side of an existing position:This prevented users from correcting mistakes, rebalancing exposure, or switching sides before market resolution.
Simply removing this validation would be unsafe because the existing payout model assumes each user has a single-sided position.
Solution
This change introduces side-aware position tracking and treats opposite-side operations as capital-preserving position switches.
Key changes
BetEntryto track exposure on both sides.Economic Safety
The implementation preserves the following invariants:
total_yesandtotal_noremain synchronized with active positions.Testing
Added/updated coverage for:
Verification
The implementation was validated using the repository's applicable:
The final Git diff was also reviewed to ensure the changes remain limited to the scope of this issue.
Scope
This PR is intentionally focused on resolving the irreversible one-sided position limitation. It does not introduce unrelated trading, order-book, leverage, or position-management functionality.
Closes: #59