Fix #51: Add governance controls to set_config (code-hash pinning, multi-sig timelock, dispute window) - #129
Open
funds0033-cmyk wants to merge 1 commit into
Conversation
…ncies cannot be silently swapped. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Problem
set_configapplied changes immediately, with no verification that the passed-in contract addresses were legitimate WASM contracts, and no oversight process for changing critical config.What landed
Config changes now go through a three-layer process instead of applying immediately:
xlm_sacis rejected. Hashes are read again at execute time, so code can't be swapped during the delay window.GovernorThresholdapprovals and a 24h delay beforeexecute_set_configcan apply it.cfg_req/cfg_ok/cfg_act/cfg_canevents are emitted at each stage, and any governor can callcancel_set_configto block a pending change before it goes live.Compatibility
initializekeeps the same 4-address ABI, so the rest of the suite should still compile. The initializer becomes the first 1-of-1 governor — production deployments should add governors and raise the threshold before relying on this.Scope
This branch is off
upstream/mainand does not include the #57 work.Branch:
fix/issue-51-set-config-governance