fix(timeline): resolve focus by event id and render non-live events - #1690
Open
eleboucher wants to merge 71 commits into
Open
fix(timeline): resolve focus by event id and render non-live events#1690eleboucher wants to merge 71 commits into
eleboucher wants to merge 71 commits into
Conversation
BurgundyDev
approved these changes
Aug 8, 2026
BurgundyDev
left a comment
BurgundyDev
left a comment
Contributor
There was a problem hiding this comment.
testing proves good from a short smoke test
Contributor
|
Actually nvm, bug happened again.... |
BurgundyDev
suggested changes
Aug 8, 2026
BurgundyDev
left a comment
BurgundyDev
left a comment
Contributor
There was a problem hiding this comment.
reverting approval cuz no fix after all, will go through code tomorrow as well
eleboucher
force-pushed
the
fix/timeline-focus-by-event-id
branch
5 times, most recently
from
August 9, 2026 15:26
6f43776 to
3de88ca
Compare
eleboucher
force-pushed
the
fix/timeline-focus-by-event-id
branch
2 times, most recently
from
August 9, 2026 17:04
af8080f to
c8703db
Compare
…and cache identity
eleboucher
force-pushed
the
fix/timeline-focus-by-event-id
branch
from
August 9, 2026 17:13
c8703db to
05caaf4
Compare
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-1690-sable.raspy-dream-bb1d.workers.dev | 70d297b | pr-1690 |
Sun, 09 Aug 2026 22:14:22 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
focus was stored as a raw index into the flattened timelines, so backward pagination shifted it onto an older message. it is now keyed by event id. also fixes late events never rendering (60s timestamp window replaced by timeline set identity) and a failed jump leaving the room blank.
Type of change
Checklist:
AI disclosure: