Repository navigation
feat(notifications): add "False Alarm" discard action with undo toast for email status changes - #97
Merged
Merged
Conversation
…y-load embeddings, and add runtime LLM fallback
…ght coalescing and button state
…r email detections
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves false-positive email classifications by introducing a "False Alarm" action directly on Dashboard notifications. Clicking it immediately reverts an auto-updated job application status back to its previous state, restores the original application date, removes the false event from the activity log, and displays an Undo toast allowing the user to restore the change if clicked by mistake.
Key Changes
1. Frontend (React / Vite)
DashboardPage.jsx):False Alarmbutton on actionable email sync notifications.✓ Revertedto prevent duplicate clicks.useNotifications.js):revertNotificationandunrevertNotificationmutations.['notifications'],['applications'], and['dailyStats'].2. Backend Orchestrator (Node.js / Express)
notifications.routes.js,notifications.controller.js):POST /api/notifications/:id/revert: Reverts application status and date, wipes the false activity log event, and marks notification as reverted.POST /api/notifications/:id/unrevert: Undoes the revert and reapplies the detected status if requested from the Undo toast.notifications.service.js):applications.dateto the previous date (from metadata snapshot or prior history event).application_history(applicationHistoryRepo.remove) without creating dummy notes, keeping the activity timeline andlast_activity_date(ghosting metrics) completely intact.mailPoller.service.js):previous_statusandprevious_datein the notificationmetadatapayload upon auto-update.notifications.repository.js):findByIdandupdatemethods with defensive fallback handling if schema columns are not yet migrated in Supabase.3. Database (Supabase)
20261106000000_add_notifications_metadata.sql):metadata JSONB DEFAULT '{}'::jsonbandreverted BOOLEAN DEFAULT falseto thenotificationstable with an index onreverted.Testing & Verification
backend/tests/services/notifications.service.test.js(7/7 tests passing).npm run test).npm run build).