Skip to content

feat(applications): add quick reject button and rejection modal to application detail page - #99

Merged
SagiEv merged 1 commit into
mainfrom
features/general
Nov 6, 2026
Merged

SagiEv merged 1 commit into
mainfrom
features/general

Conversation

@SagiEv

@SagiEv SagiEv commented Nov 6, 2026

Copy link
Copy Markdown
Owner

…plication detail page## Description
Adds the quick ✕ rejection button and rejection modal from the main tracker view into the specific application detail page (ApplicationDetailPage). This allows users to quickly mark an application as rejected with optional notes/reasons and automatic rejection flagging without navigating back to the applications table.

Changes

  • RejectModal.jsx: Extracted a reusable rejection modal component handling reason comments and the "Automatically rejected" toggle.
  • ApplicationDetailPage.jsx:
    • Added the red ✕ quick rejection button alongside status badges in the hero section for active applications (STATUS !== 'rejected' && STATUS !== 'ignored').
    • Integrated rejection modal trigger when selecting 'Rejected' in the status edit dropdown.
    • Linked modal submission to onUpdate(app.id, 'Rejected', app.STAGE, null, reason, autoReject).
    • Updated stepper and edit trigger to ensure local status reflects latest updates without unnecessary effect cascades.
  • ApplicationsPage.jsx: Replaced inline modal JSX with <RejectModal /> to ensure single source of truth across pages.
  • ApplicationDetailPage.test.jsx:
    • Added unit test covering quick reject ✕ button rendering and submission.
    • Added test verifying button hides for already rejected/ignored applications.
    • Added test verifying modal trigger from the edit dropdown.

Verification

  • Linter: npm run lint passed with 0 errors and 0 warnings.
  • Unit Tests:
    • src/pages/__tests__/ApplicationDetailPage.test.jsx (6/6 passed)
    • src/pages/__tests__/ApplicationsPage.test.jsx (2/2 passed)
    • Full frontend suite: 41/41 passed across 12 test files.

@SagiEv SagiEv linked an issue Nov 6, 2026 that may be closed by this pull request
@vercel

vercel Bot commented Nov 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
job-pilot Ready Ready Preview Nov 6, 2026 10:50am UTC

@SagiEv SagiEv added the enhancement New feature or request label Nov 6, 2026
@SagiEv
SagiEv merged commit d0d7acd into main Nov 6, 2026
6 checks passed

This branch was successfully deployed

1 active deployment
Preview — 47701a93 Deployed Nov 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick Rejection Button & Modal in Application Detail Page

1 participant