Preserve OCR failure diagnostics and organize tests by responsibility - #370
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognition failures could show a generic retry message in both the UI and logs, hiding the original exception reported in #361. Preserve worker exception types, messages, and tracebacks, and record unexpected recognition failures with execution context while keeping public error responses stable. Sync mathcraft-ocr to the published 0.3.0 release. Organize tests by their current module responsibilities, remove six ineffective or historical tests and redundant assertions, and centralize import-path setup in conftest for the reorganized modules. Validation: 398 passed, 1 skipped, 57 subtests passed; Ruff and git diff --check passed. The existing Pillow getdata deprecation warnings remain. This improves diagnosis of #361; it does not claim to resolve the underlying GPU recognition failure.