[Fix] Skip shmem for per-rank weights — use plain pinned tensor - #74
Merged
Conversation
When per_rank=True (EP scenario), each rank has unique weights and never shares them with other ranks. The mmap file was created only to be read by the same rank and immediately deleted — pure overhead. Replace _create_empty_shm + os.remove with a plain torch.empty, keeping the streaming copy-and-replace and pin_memory_in_place unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗂️ PR Category
📝 Description
When
per_rank=True(EP scenario, each rank has unique weights), the current code creates an mmap shared-memory file via_create_empty_shm, writes into it, then immediately deletes it — the file is never read by another rank. This is pure filesystem overhead.Change: Replace
_create_empty_shm+os.removewith a plaintorch.empty(), keeping the streaming_stream_copy_and_replaceandpin_memory_in_placeunchanged.The
per_rank=Falsepath (all ranks share identical weights) is untouched — it still uses mmap so rank 0 writes once and all other ranks map the same file.Before
After