Refactoring Branch - #79
Conversation
| si_scaling_factor: float, | ||
| dimensions: Dimensions): | ||
|
|
||
| self.scale = si_scaling_factor |
There was a problem hiding this comment.
Is there any reason not to call self.scale self.si_scaling_factor as well?
|
|
||
|
|
||
| # | ||
| # Units by type |
There was a problem hiding this comment.
While writing the unit tests for my parser, I had a thought. I think the unit groups should perhaps go into a separate module. To import a unit, we would do
from sasdata.quantities.units import meters. meters_per_second ...'Which makes sense. But to import a unit group, the import statement would look like this.
from sasdata.quantities.units import speed, acceleration ...'Which might be a little confusing because we're importing a unit group from the units module. Its a fairly minor change but having a separate unit group module might make this clearer.
There was a problem hiding this comment.
Yeah, sounds like a good plan
a16b0a6 to
e27d0cc
Compare
6e3ba34 to
c010919
Compare
d4683bd to
3df6e01
Compare
b32dbfe to
6f3b4af
Compare
490cec4 to
ee6af02
Compare
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ee6af02 to
15acac0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
90413d7 to
dd691e0
Compare
…w-database branch
* Refactors sasmanipulations to use new data objects for input * Refactors sasmanipulations to use new data objects for output * Adds new dataset type "angle_dim" * Uses ordinate property in manipulations code * Fixes use of "center" quantity value in tests * Addresses review comments
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Absence of Expected Change Pattern
- sasdata/sasdata/dataloader/readers/red2d_reader.py is usually changed with: sasdata/sasdata/dataloader/readers/ascii_reader.py, sasdata/sasdata/dataloader/readers/tiff_reader.py
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
5 participants
Main branch for the refactoring project