Skip to content

PR tutorial update#24

Open
wpotrzebowski wants to merge 13 commits into
masterfrom
pr_tutorial_update
Open

PR tutorial update#24
wpotrzebowski wants to merge 13 commits into
masterfrom
pr_tutorial_update

Conversation

@wpotrzebowski

@wpotrzebowski wpotrzebowski commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

P(R) tutorial updated to version 6. It seems that SasView 6 works better/has better defaults than SasView 5 and therefore it maybe not as a educational as previous version but it still demonstrates purpose.

It also has a GitHub action that auto-generates PDFs files from the new/modified fodt files.

Resolves #16 #20

@wpotrzebowski
wpotrzebowski requested a review from smk78 July 21, 2026 07:05

@smk78 smk78 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does 3 things:

  • it provides an updated P(r) Tutorial revised for the changes to this perspective as featured in SasView 6.x;
  • it introduces CI infrastructure to dynamically build Tutorial pdf's from associated .fodt files, a long-standing wish!
  • and it updates the instructions in the repo README file.

I am not competent to review the CI scripts but can see the intent and figure @wpotrzebowski has tested them!

The changes to the README look good to me.

As regards the Tutorial itself:

  • it looks like a page break has been lost immediately before Preamble;
  • does the Preamble in fact want to be replaced with the new wording in the 6.2.0 installer licence?
  • the copyright text needs reinstating;
  • comparing p9 & p10, it looks as if the first figure on p10 could be moved up slightly which ought then to allow for a blank line to be inserted on p11 after the paragraph ending 'be considered with some care'.

I think this PR also addresses the following issues:
#20
#19
#16

Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P(r) Inversion Analysis: tutorial requires updating for v6.x

2 participants