Remove Namespace save and delete methods - #1
Open
znorris wants to merge 11 commits into
Open
Conversation
The API does not support PATCH or DELETE on namespace resources. Remove these methods so they fall back to the base Resource class NotImplementedError, preventing runtime errors against the API.
The API uses modifiedAt instead of updatedAt. Update all resource classes, test helpers, and specs to match. Also fix client namespace integration test that was calling the now-removed Namespace#save.
The API expects lowercase 'liveStreams' for the JSON:API type field, not 'LiveStreams'.
Remove started_at and source (now writable). Add playback_start and playback_stop (server-managed fields).
The API allows started_at to be set by clients, so it should not be read-only.
Rename preroll_video_id/postroll_video_id to preroll_id/postroll_id. Add FIELD_MAPPINGS infrastructure to Resource base class and PatchGenerator for fields where snake_case → camelCase doesn't match the API (Campaign start_time → start, end_time → end).
Users can pass snake_case filter keys that auto-translate to camelCase for the API. Supports both top-level filter: option and nested query: { filter: ... } syntax.
Provides a discoverable list of valid webhook action strings for video, livestream, and simulcast target events.
Major version bump for breaking changes: removed Namespace save/delete, renamed Campaign fields (preroll_video_id → preroll_id, start_time → start), renamed updated_at → modified_at.
…date Gemfile.lock for v1.0.0
Fix read-only attributes (Video: add source, remove stale playback_urls/ thumbnail_url; LiveStream: remove nonexistent thumbnails), add missing type fields to request bodies (Video clip: videoCommands, SimulcastTarget create: fix casing to simulcastTargets), and add livestream.edited webhook action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API does not support PATCH or DELETE on namespace resources. Remove these methods so they fall back to the base Resource class NotImplementedError, preventing runtime errors against the API.
Migrated from GitLab MR https://git.scorevision.com/fantag/pug-client-ruby/-/merge_requests/3 (author @znorris, opened 2026-02-25). Review discussion remains readable there.