Minor iOS fixes and test instruction update - #1033
Merged
Merged
Conversation
Replace LazyColumn (unneeded for 2 items) with direct SwitchPreference/OnboardButton calls and center the toggle text, matching every other onboarding screen.
Both features gate on the shared "LastNewRelease" preference key, but computed the current minor version two different ways. Kotlin trims the custom AppVersionName Info.plist key (full x.y.z); Swift trimmed CFBundleShortVersionString, which CI already pre-trims to x.y for TestFlight grouping, so trimming it again yielded a different string. The mismatch meant each feature's "seen" write stomped the other's expected value, replaying both every launch on real builds. Also fix SharedNewReleaseDialog writing the "seen" flag from the dismiss button's composable body (fires on render) instead of its onClick handler. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The Android and iOS apps now share one codebase and UI, so the tester doc no longer treats Android as primary and iOS as an afterthought. Adds platform-specific requirements/install steps (iOS is TestFlight-invitation-only for now), a new offline maps test section, and gives ios-upgrade-from-legacy.md front matter so it renders as a linkable page. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.