Split slow tests into a nightly-only suite - #1036
Merged
Merged
Conversation
MvtTileTest.testCallouts and .replayStreetNumbers loop over every GPX fixture through the full grid/callout engine with no real assertions, taking minutes each; AudioEngineTest (except beaconList) and MvtPerformanceTest.testMapAreas do real-time audio playback / live network tile fetches for the same reason. All are now excluded from the PR-blocking test/connectedCheck runs and only execute in nightly.yaml, which also now runs the full instrumentation suite unfiltered. Also drops the commented-out instrumentation job blocks this supersedes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MvtTileTest.testCallouts and .replayStreetNumbers loop over every GPX fixture through the full grid/callout engine with no real assertions, taking minutes each; AudioEngineTest (except beaconList) and MvtPerformanceTest.testMapAreas do real-time audio playback / live network tile fetches for the same reason. All are now excluded from the PR-blocking test/connectedCheck runs and only execute in nightly.yaml, which also now runs the full instrumentation suite unfiltered. Also drops the commented-out instrumentation job blocks this supersedes.