Skip to content

feat(analytics): name the app so the first page view is attributed #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vpetersson-bot merged 1 commit into from
Aug 15, 2026
Merged

feat(analytics): name the app so the first page view is attributed #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"license": "AGPL-3.0-only",
"dependencies": {
"@screenly-labs/signage-kit": "github:Screenly-Labs/signage-kit#2026.8.8",
"@screenly-labs/signage-kit": "github:Screenly-Labs/signage-kit#2026.8.9",
"hono": "^4.12.33",
"qrcode-generator": "^2.0.4"
},
Expand Down
7 changes: 6 additions & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,11 @@ app.route('/img', img)
// (yodeck, pisignage, xogo, iadea and friends) that header is the only thing that names
// the vendor. If this response were ever cached, every screen would inherit whichever
// player happened to warm it and the census would silently collapse onto one vendor.
app.get(PLAYER_PROFILE_PATH, (c) => playerProfileResponse(c.req.raw))
//
// Naming the app here is what gets the page view attributed: the payload then carries
// ready-made user properties, which the inline bootstrap sets BEFORE gtag('config') fires
// the automatic page_view. Without it the first page view under any client_id has no player
// fields, and a screen that mints a fresh id every load never attributes one at all.
app.get(PLAYER_PROFILE_PATH, (c) => playerProfileResponse(c.req.raw, { app: 'rss-reader' }))

export default app