fix: scope GCP firewall rules per node - #83
Draft
korshunowroman wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Firewall rules were created with global names such as
allow-sshwhile theirtarget tag was node-specific. After the first node, later deployments saw the
global rule and skipped creation, leaving their VM without the required
ingress. The destroy path already looked for suffixed names such as
allow-ssh-node-1, so it could never remove the rules created by deploy.Validation
uv run ruff check deploy_gcp/seismic_deploy/gcp/compute.py deploy_gcp/seismic_deploy/gcp/test_compute.pyuv run ty check deploy_gcp/seismic_deploy/gcp/compute.py deploy_gcp/seismic_deploy/gcp/test_compute.pyuv run python -m unittest discover -s deploy_gcp -p 'test_*.py' -vpython3 -m compileall -q deploy_gcp teegit diff --checkLegacy unsuffixed firewall rules from older deployments are intentionally not
deleted automatically because their target tags may belong to another node.