fix(refresh): skip hardening-only Docker Security subsections - #24
Merged
Merged
Conversation
Docker 29.8.0 ships a ### Security subsection that only adds AppArmor and SELinux policy rules and names no CVE or GHSA identifier. The extractor treated that as a wording change and failed closed, which has held the daily minimum-versions-refresh job red since 2026-09-01 while the real minimum (29.7.0) sat unchanged one release below. A Security subsection without an identifier fixes no tracked vulnerability, so it now neither moves the minimum nor stops the refresh. The page-level guard stays: if no security release on the page names an identifier, the extractor still fails closed and lists the releases it skipped.
aliencaocao
requested review from
JordanNanos,
Prathmesh234,
functionstackx and
samharshe
as code owners
September 24, 2026 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
minimum-versions-refreshhas failed every day since 2026-09-01 with:Docker 29.8.0's
### Securitysection only adds AppArmor/SELinux policy rules (release notes) and names no identifier. The extractor treated that as a wording change and failed closed, while the real minimum (29.7.0, CVE-2026-17106) sat unchanged one release below.docker_minimums()now skips a Security subsection that names no CVE/GHSA (hardening, not a fix for a tracked vulnerability), so it neither moves the minimum nor stops the refresh. The page-level guard stays: if no security release on the page names an identifier, it still fails closed and lists the releases it skipped.Same fix is needed in ClusterMAX-internal's copy of
minimum_refresh.pyif that refresh should go green too; not included here per "don't move anything else".Tests
python3 -m pytest -q tests/audit/→ 1313 passed.Note
Low Risk
Narrows Docker minimum selection logic and error paths in the audit refresh; behavior is covered by new tests and only affects how release notes are interpreted.
Overview
Fixes
minimum-versions-refreshfailing daily on Docker 29.8.0, whose### Securitysection has no CVE/GHSA (AppArmor/SELinux hardening only).docker_minimums()now treats a Security subsection without a CVE or GHSA as hardening-only: it is skipped when picking the minimum and does not abort the job. The published minimum stays on the newest release that does name an identifier (e.g. 29.7.0). Fail-closed behavior is unchanged when every Security section on the page lacks identifiers—the error lists the skipped release versions so a real format change is still caught.Tests cover the 29.8.0 scenario and the all-hardening page case.
Reviewed by Cursor Bugbot for commit 3ec67a1. Bugbot is set up for automated code reviews on this repo. Configure here.