fix: prevent minimum refresh timeouts and handle bulletin scan exits - #25
Merged
Merged
Conversation
JordanNanos
marked this pull request as ready for review
September 25, 2026 03:44
JordanNanos
requested review from
Prathmesh234,
functionstackx and
samharshe
as code owners
September 25, 2026 03:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Evidence
The diagnostic run recorded four Ubuntu requests taking about 60 seconds each. It then rebuilt all 12 components and passed the audit tests, but incorrectly failed on the new-bulletin exit code: https://github.com/SemiAnalysisAI/ClusterMAX/actions/runs/36090373993
Validation
No minimum-version data or advisory policy changes are included. Generated data remains separate in PR #26, including the newly detected AMD-SB-6034 bulletin for human review.
Note
Low Risk
CI and generator plumbing only; no minimum table or advisory policy changes. Parallel fetches and shell exit handling are covered by new tests.
Overview
Addresses minimum-versions refresh job timeouts and a bulletin-scan false failure under GitHub Actions’
bash -e.Ubuntu package lookups in
ubuntu_minimumsnow run in parallel (ThreadPoolExecutor, up to four workers) instead of sequentially, cutting wall time when each CVE/API call can take ~60s. Order and fail-closed behavior are unchanged:pool.mapkeeps package key order and still aborts the whole refresh on any package error.Observability:
Fetcherroutes all HTTP through a_openhelper that logs method, URL, and elapsed time at INFO (never headers orGITHUB_TOKEN). A new--verboseflag turns that on; the workflow refresh step usespython3 -uand--verbosefor unbuffered CI logs.Bulletin detection shell: The detect-new-bulletins step captures the Python exit code inside an
if/elseso expected exit 3 (untracked bulletin found) is handled as success for retry/found=truelogic instead of errexit killing the script and mis-reporting a failed scan. Transient failures still retry three times.New audit tests cover credential-free fetch logging, Ubuntu concurrency/error propagation, and exit codes 0/2/3 under
bash -eagainst the workflow script.Reviewed by Cursor Bugbot for commit 426b41c. Bugbot is set up for automated code reviews on this repo. Configure here.