Skip to content

[Klaud Cold] Update Qwen3.5 FP8 MI355X ATOM MTP image to v0.1.7 / [Klaud Cold] 将 Qwen3.5 FP8 MI355X ATOM MTP 镜像更新至 v0.1.7 - #3918

Merged
adibarra merged 7 commits into
mainfrom
klaud/auto-c0a103b929f95b7c-d7d3a8ed94c43625
Oct 20, 2026
Merged

adibarra merged 7 commits into
mainfrom
klaud/auto-c0a103b929f95b7c-d7d3a8ed94c43625

Conversation

@Klaud-Cold

@Klaud-Cold Klaud-Cold commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Goal: Update ATOM image from rocm/atom:rocm7.2.2_ubuntu24.04_py3.12_pytorch_release_2.10.0_atom0.1.2.post to rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb.
Baseline: 2026-05-22 · rocm/atom:rocm7.2.2_ubuntu24.04_py3.12_pytorch_release_2.10.0_atom0.1.2.post
Mean latency · Sources: API 1, API 2, API 3

Point Total tok/s/GPU ↑ Output tok/s/GPU ↑ TTFT ms ↓ TPOT ms ↓
1k/1k c4 TP4 EP1 7303f8 371.05 184.09 122.31 5.1
1k/1k c4 TP8 EP1 dd674d 223.66 110.96 123.37 4.19
1k/1k c8 TP4 EP1 a1a381 625.44 313.06 135.22 5.96
1k/1k c8 TP8 EP1 a553cc 395.25 197.82 126.36 4.7
1k/1k c16 TP4 EP1 d7c0e2 983.61 488.61 155.28 7.82
1k/1k c16 TP8 EP1 a4d7e1 541.25 268.87 150.2 7.04
1k/1k c32 TP4 EP1 6fb399 1,394.84 697.45 187.2 10.91
1k/1k c32 TP8 EP1 f35014 839.39 419.7 178.65 9.07
1k/1k c64 TP4 EP1 191187 2,079.85 1,037.13 257.6 14.76
1k/1k c64 TP8 EP1 457676 1,247.07 621.87 230.41 12.3
1k/1k c128 TP4 EP1 163ecc 2,779.45 1,385.06 346.56 22.21
1k/1k c128 TP8 EP1 55e615 1,681.06 837.7 301.56 18.4
1k/1k c256 TP4 EP1 50d77c 3,523.02 1,758.29 610.85 34.95
1k/1k c256 TP8 EP1 902ea9 2,190.41 1,093.17 551.97 28.08
8k/1k c4 TP4 EP1 ebd43b 1,497.23 166.01 308.37 5.57
8k/1k c4 TP8 EP1 efbfb6 929.8 103.11 250.41 4.46
8k/1k c8 TP4 EP1 76b9a0 2,422.31 271.62 357.85 6.84
8k/1k c8 TP8 EP1 45218c 1,526.21 171.11 290.65 5.36
8k/1k c16 TP4 EP1 d94eb0 3,411.54 376.83 437.66 9.78
8k/1k c16 TP8 EP1 efedb9 2,017.53 222.89 371.67 8.3
8k/1k c32 TP4 EP1 c6cdbf 4,589.15 511.59 647.79 14.58
8k/1k c32 TP8 EP1 8c32f2 2,907.79 324.19 536.03 11.48
8k/1k c64 TP4 EP1 3ae1ba 5,841.74 646.1 992.31 23.27
8k/1k c64 TP8 EP1 74669c 3,783.28 418.42 795.14 17.84
8k/1k c128 TP4 EP1 89488d 6,985.06 771.32 1,637.78 39.2
8k/1k c128 TP8 EP1 1e8939 4,621.05 510.27 1,278.83 29.5
8k/1k c256 TP4 EP1 d31896 7,735.07 857.24 3,070.54 70.45
8k/1k c256 TP8 EP1 e840c5 5,134.46 569.09 2,295.1 53.11

Note: 1k/1k c4 TP4 EP1 7303f8, 1k/1k c4 TP8 EP1 dd674d, 1k/1k c8 TP4 EP1 a1a381, 1k/1k c8 TP8 EP1 a553cc, 1k/1k c16 TP4 EP1 d7c0e2, 1k/1k c16 TP8 EP1 a4d7e1, 1k/1k c32 TP4 EP1 6fb399, 1k/1k c32 TP8 EP1 f35014, 1k/1k c64 TP4 EP1 191187, 1k/1k c64 TP8 EP1 457676, 1k/1k c128 TP4 EP1 163ecc, 1k/1k c128 TP8 EP1 55e615, 1k/1k c256 TP4 EP1 50d77c, 1k/1k c256 TP8 EP1 902ea9: Single-turn 1k1k retired 2026-07-17 in #2263 after this baseline; excluded from coverage.

Eval Score ↑ Samples
gsm8k/em_strict · 8k/1k TP4 c256 96.74% 1,319
gsm8k/em_strict · 8k/1k TP4 c64 97.19% 1,319
gsm8k/em_strict · 8k/1k TP8 c256 97.12% 1,319
gsm8k/em_strict · 8k/1k TP8 c64 97.04% 1,319
中文

**目标:**将 ATOM 镜像从 rocm/atom:rocm7.2.2_ubuntu24.04_py3.12_pytorch_release_2.10.0_atom0.1.2.post 更新为 rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb。
**基线:**2026-05-22 · rocm/atom:rocm7.2.2_ubuntu24.04_py3.12_pytorch_release_2.10.0_atom0.1.2.post
平均延迟 · 来源: API 1, API 2, API 3;数值及异常说明见上表。

Move qwen3.5-fp8-mi355x-atom-mtp from rocm/atom atom0.1.2.post to the
digest-pinned rocm/atom-dev:nightly_202610080328 build of ATOM v0.1.7.

将 qwen3.5-fp8-mi355x-atom-mtp 从 rocm/atom atom0.1.2.post 更新为按摘要固定的
ATOM v0.1.7 构建 rocm/atom-dev:nightly_202610080328。

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps run only when the PR appends an inferencex-e2e/perf-changelog.yaml entry and carries exactly one primary label: full-sweep-fail-fast (strongly recommended; canary plus per-matrix fail-fast), full-sweep-enabled (canary; matrix jobs continue after a failure), or non-canary-full-sweep-enabled (no canary or fail-fast). The modifiers all-evals, evals-only, and agentx-fast require a primary label. On fork PRs, a maintainer applies the label. See sweep labels and reuse.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**只有当 PR 在 inferencex-e2e/perf-changelog.yaml 末尾追加了条目,并且恰好带有一个主标签时,才会运行扫描:full-sweep-fail-fast(强烈推荐;canary 加逐矩阵 fail-fast)、full-sweep-enabled(有 canary;矩阵任务在失败后继续运行)或 non-canary-full-sweep-enabled(无 canary,也无 fail-fast)。修饰标签 all-evals、evals-only 和 agentx-fast 必须与主标签一起使用。fork PR 的标签由维护者添加。参见扫描标签与复用。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

@Klaud-Cold

Klaud-Cold commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

Initial attempt · Passed · Run 38190921586 / attempt 1 · 2026-10-12 01:38 UTC
rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb · c801c9f2dbbd · Mean latency
Change: Measured f93d2d0: image-only move to ATOM v0.1.7 a526f0d5 (OCI labels, ROCm 7.2.4) from unpinned HEAD built 2026-04-22 (~f4478c5e, inferred; AITER unverified); recipe flags parse unchanged in arg_utils.py, prefix caching and chunked prefill now default on. TP4 c4 means include a one-time 33.5 s AITER JIT build after a prefix-cache hit (median TTFT 315 ms).

Point Output tok/s/GPU ↑ TTFT ms ↓ TPOT ms ↓
8k/1k c4 TP4 EP1 ebd43b 107.18 (-35.4%) 1,201.8 (+289.7%) 7.73 (+38.7%)
8k/1k c4 TP8 EP1 efbfb6 108.76 (+5.5%) 336.34 (+34.3%) 4.13 (-7.3%)

Note: All rows: request errors unavailable.

Eval Score ↑ Samples
gsm8k/em_strict · 8k/1k TP4 c64 96.66% (-0.53 pp) 1,319 each
gsm8k/em_strict · 8k/1k TP8 c64 96.74% (-0.30 pp) 1,319 each

Next: Append the changelog entry and run the final full sweep.

中文

初次尝试 · 已通过 · Run 38190921586 / attempt 1 · 2026-10-12 01:38 UTC
rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb · c801c9f2dbbd · 平均延迟
**变更:**实测提交 f93d2d0:仅将镜像更换为 ATOM v0.1.7(a526f0d5,ROCm 7.2.4);旧镜像由 2026-04-22 未固定的 HEAD 构建(约 f4478c5e,推断;AITER 未核实)。配方参数解析不变,前缀缓存与分块预填充现默认开启。TP4 c4 平均值包含前缀缓存命中后一次性的 33.5 秒 AITER JIT 编译(TTFT 中位数 315 ms)。实测数值及异常说明见上表。
**下一步:**追加 changelog 条目并运行最终完整 sweep。

为 Qwen3.5 FP8 MI355X ATOM MTP 的 v0.1.7 镜像更新追加 perf-changelog 条目。

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Klaud-Cold Klaud-Cold added the full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended) label Oct 12, 2026
@Klaud-Cold

Klaud-Cold commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

Final full sweep · Passed · Run 38192728482 / attempt 1 · 2026-10-12 02:41 UTC
rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb · 623e9bd532ef · Mean latency
Change: Append the perf-changelog entry and run the full-sweep-fail-fast sweep with the unchanged v0.1.7 image and recipe.

Point Output tok/s/GPU ↑ TTFT ms ↓ TPOT ms ↓
8k/1k c4 TP4 EP1 ebd43b 107.94 (-35%) 1,181.74 (+283.2%) 7.69 (+38.1%)
8k/1k c8 TP4 EP1 76b9a0 165.22 (-39.2%) 1,117.24 (+212.2%) 10.6 (+55%)
8k/1k c16 TP4 EP1 d94eb0 259.74 (-31.1%) 882.86 (+101.7%) 14.14 (+44.6%)
8k/1k c32 TP4 EP1 c6cdbf 413.55 (-19.2%) 831.5 (+28.4%) 18.14 (+24.4%)
8k/1k c64 TP4 EP1 3ae1ba 560.65 (-13.2%) 1,137.2 (+14.6%) 26.99 (+16%)
8k/1k c128 TP4 EP1 89488d 711.42 (-7.8%) 1,777.79 (+8.5%) 42.53 (+8.5%)
8k/1k c256 TP4 EP1 d31896 805.93 (-6%) 2,882.68 (-6.1%) 75.59 (+7.3%)
8k/1k c4 TP8 EP1 efbfb6 64.03 (-37.9%) 1,008.99 (+302.9%) 6.46 (+44.8%)
8k/1k c8 TP8 EP1 45218c 97.9 (-42.8%) 1,108.84 (+281.5%) 8.77 (+63.7%)
8k/1k c16 TP8 EP1 efedb9 156.92 (-29.6%) 723.68 (+94.7%) 11.76 (+41.7%)
8k/1k c32 TP8 EP1 8c32f2 260.35 (-19.7%) 650.35 (+21.3%) 14.4 (+25.4%)
8k/1k c64 TP8 EP1 74669c 358.42 (-14.3%) 1,004.29 (+26.3%) 20.89 (+17.1%)
8k/1k c128 TP8 EP1 1e8939 461.33 (-9.6%) 1,416.16 (+10.7%) 32.82 (+11.3%)
8k/1k c256 TP8 EP1 e840c5 543.17 (-4.6%) 2,329.21 (+1.5%) 55.86 (+5.2%)

Note: All rows: request errors unavailable.

Eval Score ↑ Samples
gsm8k/em_strict · 8k/1k TP4 c64 97.04% (-0.15 pp) 1,319 each
gsm8k/em_strict · 8k/1k TP4 c256 96.82% (+0.08 pp) 1,319 each
gsm8k/em_strict · 8k/1k TP8 c64 97.12% (+0.08 pp) 1,319 each
gsm8k/em_strict · 8k/1k TP8 c256 96.74% (-0.38 pp) 1,319 each

Note: 1k/1k c4 TP4 EP1 7303f8, 1k/1k c4 TP8 EP1 dd674d, 1k/1k c8 TP4 EP1 a1a381, 1k/1k c8 TP8 EP1 a553cc, 1k/1k c16 TP4 EP1 d7c0e2, 1k/1k c16 TP8 EP1 a4d7e1, 1k/1k c32 TP4 EP1 6fb399, 1k/1k c32 TP8 EP1 f35014, 1k/1k c64 TP4 EP1 191187, 1k/1k c64 TP8 EP1 457676, 1k/1k c128 TP4 EP1 163ecc, 1k/1k c128 TP8 EP1 55e615, 1k/1k c256 TP4 EP1 50d77c, 1k/1k c256 TP8 EP1 902ea9: Single-turn 1k1k retired 2026-07-17 in #2263 after this baseline; excluded from coverage.

Next: Repair the in-run JIT stalls by keeping prefix caching off, then rerun the final sweep.

中文

最终完整 sweep · 已通过 · Run 38192728482 / attempt 1 · 2026-10-12 02:41 UTC
rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb · 623e9bd532ef · 平均延迟
**变更:**追加 perf-changelog 条目,并以未改动的 v0.1.7 镜像和配方运行 full-sweep-fail-fast 完整 sweep。实测数值及异常说明见上表。
**下一步:**通过保持前缀缓存关闭修复测量期间的 JIT 停顿,然后重新运行最终 sweep。

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

@Klaud-Cold Klaud-Cold removed the full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended) label Oct 12, 2026
ATOM v0.1.7 enables prefix caching by default; the old image did not.
Cache hits on reused benchmark prompts triggered in-run AITER JIT builds.

ATOM v0.1.7 默认开启前缀缓存,而旧镜像未开启。基准测试复用提示词导致的缓存命中
在测量期间触发了 AITER JIT 编译,因此保持前缀缓存关闭。

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Klaud-Cold

Klaud-Cold commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

Repair 1/5 · Passed · Run 38196729419 / attempt 1 · 2026-10-12 03:05 UTC
rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb · c801c9f2dbbd · Mean latency
Change: Measured 267cfbe: final run 38192728482 passed but means regressed 5-43% while medians matched the baseline; prefix-cache hits on reused benchmark prompts triggered 28-34 s in-run AITER mha_varlen_fwd JIT builds. Add no-enable_prefix_caching: true (BooleanOptionalAction, default on in v0.1.7) to restore the old image's default-off behavior.

Point Output tok/s/GPU ↑ TTFT ms ↓ TPOT ms ↓
8k/1k c4 TP4 EP1 ebd43b 183.18 (+10.3%) 293.84 (-4.7%) 5.01 (-10%)
8k/1k c4 TP8 EP1 efbfb6 114.94 (+11.5%) 230.73 (-7.9%) 4.03 (-9.6%)

Note: All rows: request errors unavailable.

Eval Score ↑ Samples
gsm8k/em_strict · 8k/1k TP4 c64 96.74% (-0.45 pp) 1,319 each
gsm8k/em_strict · 8k/1k TP8 c64 97.12% (+0.08 pp) 1,319 each

Next: Run the final full sweep.

中文

修复 1/5 · 已通过 · Run 38196729419 / attempt 1 · 2026-10-12 03:05 UTC
rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb · c801c9f2dbbd · 平均延迟
**变更:**实测提交 267cfbe:最终运行 38192728482 通过,但平均值退化 5-43%,中位数与基线一致;复用基准提示词导致的前缀缓存命中在测量期间触发了 28-34 秒的 AITER mha_varlen_fwd JIT 编译。添加 no-enable_prefix_caching: true,恢复旧镜像默认关闭前缀缓存的行为。实测数值及异常说明见上表。
**下一步:**运行最终完整 sweep。

Keep this PR's perf-changelog block at the physical tail after #3819.

合并 origin/main,并将本 PR 的 perf-changelog 条目保留在文件末尾。

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Klaud-Cold Klaud-Cold added the full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended) label Oct 12, 2026
@Klaud-Cold

Klaud-Cold commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

Final full sweep · Passed · Run 38198420473 / attempt 1 · 2026-10-12 03:56 UTC
rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb · 965189d17972 · Mean latency
Change: Validate the complete updated-image family at this head.

Point Output tok/s/GPU ↑ TTFT ms ↓ TPOT ms ↓
8k/1k c4 TP4 EP1 ebd43b 184.41 (+11.1%) 251.37 (-18.5%) 5.05 (-9.4%)
8k/1k c4 TP8 EP1 efbfb6 114.85 (+11.4%) 239.51 (-4.4%) 3.98 (-10.7%)
8k/1k c8 TP4 EP1 76b9a0 295.22 (+8.7%) 366.03 (+2.3%) 6.19 (-9.5%)
8k/1k c8 TP8 EP1 45218c 189.36 (+10.7%) 239.34 (-17.7%) 4.86 (-9.3%)
8k/1k c16 TP4 EP1 d94eb0 419.22 (+11.3%) 422.03 (-3.6%) 8.83 (-9.8%)
8k/1k c16 TP8 EP1 efedb9 274.07 (+23%) 319.53 (-14%) 6.74 (-18.8%)
8k/1k c32 TP4 EP1 c6cdbf 570.04 (+11.4%) 578.21 (-10.7%) 13.15 (-9.8%)
8k/1k c32 TP8 EP1 8c32f2 383.82 (+18.4%) 498.3 (-7%) 9.64 (-16%)
8k/1k c64 TP4 EP1 3ae1ba 711.38 (+10.1%) 863.78 (-13%) 21.14 (-9.2%)
8k/1k c64 TP8 EP1 74669c 492.82 (+17.8%) 740.78 (-6.8%) 15.17 (-15%)
8k/1k c128 TP4 EP1 89488d 866.67 (+12.4%) 1,550.67 (-5.3%) 34.78 (-11.3%)
8k/1k c128 TP8 EP1 1e8939 585.63 (+14.8%) 1,215.02 (-5%) 25.66 (-13%)
8k/1k c256 TP4 EP1 d31896 967.01 (+12.8%) 2,768.16 (-9.8%) 62.33 (-11.5%)
8k/1k c256 TP8 EP1 e840c5 657.15 (+15.5%) 2,132.92 (-7.1%) 45.83 (-13.7%)

Note: All rows: request errors unavailable.

Eval Score ↑ Samples
gsm8k/em_strict · c64 96.66% (-0.53 pp) 1,319 each
gsm8k/em_strict · c64 96.97% (-0.08 pp) 1,319 each
gsm8k/em_strict · c256 96.74% (-0.38 pp) 1,319 each
gsm8k/em_strict · c256 96.51% (-0.23 pp) 1,319 each

Note: 1k/1k c4 TP4 EP1 7303f8, 1k/1k c4 TP8 EP1 dd674d, 1k/1k c8 TP4 EP1 a1a381, 1k/1k c8 TP8 EP1 a553cc, 1k/1k c16 TP4 EP1 d7c0e2, 1k/1k c16 TP8 EP1 a4d7e1, 1k/1k c32 TP4 EP1 6fb399, 1k/1k c32 TP8 EP1 f35014, 1k/1k c64 TP4 EP1 191187, 1k/1k c64 TP8 EP1 457676, 1k/1k c128 TP4 EP1 163ecc, 1k/1k c128 TP8 EP1 55e615, 1k/1k c256 TP4 EP1 50d77c, 1k/1k c256 TP8 EP1 902ea9: Single-turn 1k1k retired 2026-07-17 in #2263 after this baseline; excluded from coverage.

Next: Mark ready for maintainer review.

中文

最终完整 sweep · 已通过 · Run 38198420473 / attempt 1 · 2026-10-12 03:56 UTC
rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb · 965189d17972 · 平均延迟
**变更:**验证此提交更新镜像后的完整配置族。实测数值及异常说明见上表。
**下一步:**标记为就绪,等待维护者审查。

@Klaud-Cold
Klaud-Cold marked this pull request as ready for review October 12, 2026 03:57
@Klaud-Cold
Klaud-Cold requested a review from a team October 12, 2026 03:57
@Klaud-Cold

Copy link
Copy Markdown
Collaborator Author

validated · Repairs: 1 · Runs: 38190921586, 38192708421, 38192728482, 38196707365, 38196728215, 38196729419, 38198402715, 38198420473
All owned runs ended. Full sweep verified; ready for review.

中文

validated · 修复次数:1 · 运行:38190921586, 38192708421, 38192728482, 38196707365, 38196728215, 38196729419, 38198402715, 38198420473
所有自有运行均已结束。完整 sweep 已验证;已就绪,等待审查。

@Klaud-Cold

Copy link
Copy Markdown
Collaborator Author

/use 38198420473

@claude

claude Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @Klaud-Cold's task in 17s —— View job


LGTM - no blocking issues found

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

@Klaud-Cold staged run 38198420473: https://inferencemax-app-git-staging-semianalysisai.vercel.app/inference?i_dates=2026-10-12~r38198420473

This run remains available across future /stage-results requests. Staging the same run ID again updates its staged data. Staging workflow

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. Because this bumps the ATOM serving container for an MTP (speculative-decoding) recipe to an unpinned-release nightly build, and inferencex-e2e/configs/amd-master.yaml is owned by a non-core CODEOWNER group (requiring sign-off per CONTRIBUTING.md), a human/CODEOWNER look would still be worthwhile.

What was reviewed: the image-bump pairing between the recipe YAML's model.container and amd-master.yaml's image (identical new digest in both, satisfying the "must match" invariant); the new no-enable_prefix_caching: true flag as a plausible behavior-preserving addition alongside the image bump; and the perf-changelog.yaml entry (appended at the tail, correct config-key, English-only, with a PR link). Not visible in the diff or PR text is the CODEOWNER "additional detail section" CONTRIBUTING.md's draft-model-precision rule requires for MTP changes (draft checkpoint/revision, shipped precision, and confirmation the new ATOM nightly's default handling still matches it) — worth a CODEOWNER confirming before merge, since the rule explicitly treats image-only bumps as not exempt.

Extended reasoning...

Config-only diff (recipe YAML + master config + changelog) for an AMD MI355X MTP benchmark; no application code, auth, or injection surface touched. The decisive facts: amd-master.yaml carries a non-core CODEOWNER list requiring sign-off, and CONTRIBUTING.md's draft-model-precision rule specifically calls out image-only bumps on speculative-decoding recipes as requiring a reviewer-visible precision confirmation, which isn't present in what's available here, so I deferred rather than approved.

Resolve conflicts: take main's refactored recipes and re-apply this PR's non-image edits; take main's perf-changelog.yaml and re-append this PR's entry.

中文:合并 origin/main;配方采用 main 重构后的版本并重新应用本 PR 的非镜像改动,perf-changelog.yaml 采用 main 版本并在末尾重新追加本 PR 的条目。
@adibarra
adibarra requested a review from zijiecode as a code owner October 20, 2026 15:19
Resolve conflicts: take main's refactored recipes and re-apply this PR's non-image edits; take main's perf-changelog.yaml and re-append this PR's entry.

中文:合并 origin/main;配方采用 main 重构后的版本并重新应用本 PR 的非镜像改动,perf-changelog.yaml 采用 main 版本并在末尾重新追加本 PR 的条目。
@adibarra

Copy link
Copy Markdown
Collaborator

/reuse-sweep-run 38198420473

@adibarra
adibarra merged commit 7839b16 into main Oct 20, 2026
26 checks passed
@adibarra
adibarra deleted the klaud/auto-c0a103b929f95b7c-d7d3a8ed94c43625 branch October 20, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants