Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(agentx): retune GLM-5.2 FP4 MI355X ATOM recipe on nightly_202610181506 / feat(agentx):基于 nightly_202610181506 重新调优 GLM-5.2 FP4 MI355X ATOM recipe #4308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(agentx): retune GLM-5.2 FP4 MI355X ATOM recipe on nightly_202610181506 / feat(agentx):基于 nightly_202610181506 重新调优 GLM-5.2 FP4 MI355X ATOM recipe #4308
Changes from all commits
2bf45f62f1734ead9726ec919625da0a7de60f70b4dae1916001e5b64cbffd76535bafe9306f2712f1a85bfe371File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 nit (optional): Two comment blocks this PR rewrote break the mandatory AGENTS.md comment rules. Maintainers get header text that restates the config, plus upstream-PR provenance. The amd-master.yaml:1464-1470 block sits above the config key, describes the topology, and cites "matching the standalone recipe (ROCm/ATOM PR 2632)". The agentic.yaml:43-47 block sits above override_tp4_c1 and repeats each override's draft depth. Fix: drop both header blocks. Move only the non-obvious reasons (why ATOM_MONO_ENABLE is '0' by default, the 1109 GB vs 1099.5 GB sizing) into short comments on the exact lines they explain. [also at: inferencex-e2e/benchmarks/single_node/srt-slurm-recipes/glm5.2/atom/mi355x-fp4-mtp/agentic.yaml:47 - nit: The comments this PR rewrote break the AGENTS.md comment rules, so maintainers get header and provenance text that drifts out of date as values change.]
Why this was flagged
AGENTS.md:64 says "Never add broad, overarching comments ... above a recipe, override, or section". AGENTS.md:65 bans history and provenance comments ("where it was derived from"). The diff rewrites amd-master.yaml:1464-1470 to cite "ROCm/ATOM PR 2632" and to list the draft depth for each concurrency point, which the recipe already encodes. It also rewrites the header at agentic.yaml:43-47 above override_tp4_c1, which restates the num-speculative-tokens and DCP settings in the overrides below it. Both blocks exist on the base, but this PR re-authors them, so the convention slip now lands in new text. Nothing changes at runtime. The cost is maintainability: these restatements go stale the next time a draft depth changes, and the PR link is history that perf-changelog.yaml already records.
Verification: The trigger is that this PR rewrites both comment blocks. AGENTS.md:65 bans comments about "where it was derived from". The amd-master.yaml:1464-1470 block sits directly above
glm5.2-fp4-mi355x-atom-agentic-mtp:. It cites provenance ("matching the standalone recipe (ROCm/ATOM PR 2632)"), and this PR changed that PR number from 2345. Nothing breaks at runtime.Uh oh!
There was an error while loading. Please reload this page.