CI hardening: reject superseded rolling publishers - #6
Draft
mark-e-deyoung wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Prevent an older in-flight push from overwriting a newer
semper-exp-currentcandidate after publication authority is narrowed to branch pushes.Implements #3 as a separate stacked change on top of #5.
Change
publish-experimentaljob with a dedicated concurrency group and cancellation of superseded publisher jobs;semper/compile-observerbranch head and fail closed unless it still equals this workflow's candidate SHA.Why both controls
Concurrency reduces overlapping write-capable publishers, but cancellation is cooperative. The branch-head check prevents a slower older build from publishing after a newer branch head already exists even if that older workflow reaches the publisher later.
Stack / rollout
This PR targets
hardening/push-only-experimental-publisherso its diff remains independent from #5. Neither branch is the release-triggeringsemper/compile-observerbranch.Do not retarget/merge into the release branch until #5 and the private promotion state are ready.
Closes #3 when the stacked change ultimately lands on
semper/compile-observer.