Update Swagger documentation for Metrics API - #12
Merged
Conversation
Arthur-Bottemanne
requested review from
Guillaume1868
and removed request for
JulienLouisSchneider
March 5, 2026 12:57
Guillaume1868
requested changes
Mar 5, 2026
| } | ||
| } | ||
| }, | ||
| "/api/v1/metrics/query": { |
Contributor
There was a problem hiding this comment.
Add a comment to specify that this route is here to send a raw VM query. And we should consider adding a specialized route instead of writing VM specific language in other parts of the project.
This route is here for convinience but is not recommended for best practices
You can merge this PR once that comment is added
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Changes Made