Repository navigation
Conversation
…ith bars, colons in the note runs) stops the request before the semantic stage, in seconds, with the reason
…efault 2, up to 8) draws song i's attempt k with lm_seed + i + k * lm_batch_size before the request stops
…thrown away A plan whose only fault is a missing or malformed M:/L:/K: header was retried on new seeds and then thrown away once the retries were spent - the top telemetry failure for generated songs. When the body is otherwise singable (a voice with bars, no stray colons), the header is now filled in with the conventions the model is trained on (M:4/4, L:1/16, K:C), the meter and length ahead of the key, and the plan is kept. yue2_score_problem re-checks the result, so a plan wrong in other ways still fails as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #21 (plan_retries) — this branch is
plan-retriesplus one commit, so the diff shows #21's commits until it merges; please take #21 first, then this rebases cleanly onto master.A planned score whose only fault is a missing or malformed
M:/L:/K:header is retried on new seeds and then discarded once the retries are spent — in our telemetry the top failure for finished-but-rejected songs. When the body is otherwise singable (a voice with bars, no stray colons in the note runs),yue2_score_fill_headernow fills the header with the conventions the model is trained on —M:4/4,L:1/16,K:C, meter and unit length before the key — and the plan is kept.yue2_score_problemre-checks the filled score, so a plan wrong in any other way still fails exactly as before.src/score-check.h:yue2_score_fill_header+ the header-only check.src/pipeline.h: fill then re-check before the semantic stage.tests/test-score-check.cpp: a headerless-but-singable plan is filled; a plan with stray colons is still rejected.