Repository navigation
Regenerate on table save and delete files of deleted tables (1.3.4) - #22
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes #14 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerate on save only. Removed the Localization editor event subscriptions (key/entry/collection/locale edits) that regenerated code on every in-memory change, e.g. right after creating a key. Generation now runs when table assets are saved (Ctrl+S / File > Save Project) or change on disk, through the asset postprocessor.
Fixes Generated file don't deleted after table deleted #14: generated files not deleted after deleting tables. Cleanup was skipped in two cases:
Each run now records the collection and shared table data asset paths. When the postprocessor sees one of them (or a folder holding one) deleted, the next run treats missing collections as removed: their files are deleted, the last one included, without a prompt. Older projects get the paths recorded by the startup staleness check.
Version 1.3.4, CHANGELOG, README and the "Regenerate On Changes" tooltip updated.
Test plan
GenerationIntegrationTests: recorded paths, deleting the last collection, and a collection whose shared data was deleted.g.cs🤖 Generated with Claude Code