Repository navigation
Decode MXP entities and take the Pueblo hello out of connect screens - #204
Merged
Merged
Conversation
TelnetNegotiationCore 4.6.1. The MXP plugin now asks it to decode entities
once MXP mode starts: CoffeeMud escapes every quote from the moment option
91 is agreed, and CoffeeMud Hardcore's screen was stored with " in its
ASCII art.
PuebloProtocol is registered to consume the hello ("This world is Pueblo
1.10 Enhanced." from PennMUSH, "1.0" from TinyMUX and RhostMUSH), which was
stored as the first line of the screen. Nothing is sent back. The hello is
noted as PUEBLO, measured, as MCP's offer is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rqqt7TucGdYhFwbzK7RHR5
|
Caution Review failedThe pull request is closed.
CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Grave · project thread
Bumps TelnetNegotiationCore to 4.6.1 (TNC #176).
MXP entities
CoffeeMud escapes
"as"once option 91 is agreed, so CoffeeMud Hardcore's connect screen was stored with"in its ASCII art.Watched.Mxpnow callsDecodeEntities(). TNC decodes" & < >and numeric entities only after MXP mode starts, so a game that prints"without MXP keeps it.Pueblo hello
PuebloProtocolis now registered. It consumesThis world is Pueblo 1.10 Enhanced.(PennMUSH) and… 1.0 Enhanced.(TinyMUX, RhostMUSH), which were stored as the first line of the screen. The probe never sendsPUEBLOCLIENT: that is text at a login prompt and would switch the session to HTML. The hello is noted asPUEBLOin the measured capabilities, as MCP's offer already is, socapability.pueblo.measuredsits beside MSSP's declaredPUEBLO.Tests
MxpSupportTests.EntitiesInTheScreenAreDecodedProbeSessionTests.APuebloHelloIsNotPartOfTheConnectScreen(1.10 and 1.0): the hello is gone,PUEBLOis noted, nothing startingPUEBLOCLIENTwas sent.Not built locally (no .NET SDK in this environment); CI is the build.
Generated by Claude Code