Skip to content

Close the gaps between connect-screen rows - #206

Merged
HarryCordewener merged 1 commit into
mainfrom
claude/project-thread-hykooo
Nov 6, 2026
Merged

HarryCordewener merged 1 commit into
mainfrom
claude/project-thread-hykooo

Conversation

@HarryCordewener

Copy link
Copy Markdown
Member

Requested by Grave · project thread

On /g/calim-s-revenge the blue background behind the credits block drew as separate stripes, and box-drawing sides broke between rows. The ANSI frame used prose leading (1.4), and an inline span paints its background over the font's content area only, so each row's colour stopped short of the next.

  • figure.ansi .quote pre line-height 1.4 → 1.15, just under the natural height of Cascadia Mono and DejaVu Sans Mono (1.16–1.17), so │ on consecutive rows joins.
  • Styled runs are display: inline-block, so each is exactly one line tall and its background meets the row below whatever fallback font the device uses. Paint closes every run at the row's end, so nothing can wrap.
  • Scroll cap 33em → 30em, about 26 rows at the new leading.

Checked with Playwright/Chromium (DejaVu Sans Mono) on a mock of the Calim's Revenge block plus a box-drawing frame: before, gaps between the blue rows and at box corners; after, a solid bar and closed box. Not checked on the live site or on Android's fallback fonts.


Generated by Claude Code

The ANSI frame used prose leading (1.4), so a background colour on
consecutive rows drew as separate stripes and box-drawing sides broke
between rows. Set terminal leading (1.15) and make each styled run an
inline block, so its background fills the whole line whatever font the
device falls back to. The scroll cap drops to 30em to keep about 26 rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rqqt7UDmRSD2zzqkCxEn78
@HarryCordewener HarryCordewener self-assigned this Nov 6, 2026
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

@HarryCordewener
HarryCordewener marked this pull request as ready for review November 6, 2026 17:44
@HarryCordewener
HarryCordewener merged commit 13d8f0c into main Nov 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants