Repository navigation
Improve Sixel colour quality and recognize MudForge graphics - #85
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughGIF and Sixel encoding now share an adaptive median-cut palette implementation. Sixel tests validate decoded colors and grey-shade accuracy. The changes also add and document the MudForge terminal profile. ChangesAdaptive image palettes
MudForge terminal profile
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Merge Risk:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MudForge reports
MUDFORGEbut does not forward terminal-query replies. Recognize its live-verified still iTerm2 and Sixel support without opting the player into graphics or claiming animation/Kitty support.Replace Sixel's fixed 216-colour cube with an adaptive 255-colour palette, reusing GIF's existing bounded median-cut implementation. GIF behaviour is unchanged; transparency retains its reserved index. The grayscale round-trip regression failed with average channel error 12.6875 before the change and passes a threshold below 3 afterward. Existing round-trip tests now check decoded colours and transparency independently of palette slot numbers.
Validation: all 1,594 MarkupString tests pass. Independent static review found no actionable issues. Live MudForge placement investigation also confirmed an unrelated client DPI bug: its generic canvas correction divides the image addon's already-CSS-sized canvas by DPR; temporarily correcting that layer places repeated iTerm2 images correctly. This PR does not compensate server output for that client bug.
Release these packages together; SharpMUSH needs a subsequent package-version update to consume the profile and palette changes.
Summary by CodeRabbit