[HarryCordewener]

Part of the 1.0 readiness pass, workstream Q2 (SharpMUSH/SharpMUSH#2561).

An encounter stores its room as objid(%l). The join, add, leave and end notices compared that stored value with %l or loc(), which return the bare dbref. SharpMUSH#2561 makes loc() return the bare dbref too, as PennMUSH does. Because the stored objid and the bare dbref never match, the "you are not in its room" notices went to people who were standing in the room.

This PR changes the four comparisons to use objid(%l) and objid(loc(...)). Those match the stored objid both before and after SharpMUSH#2561, so the two PRs can merge in either order.

• sheet-charge/package.yaml: the four comp() calls, and version 1.2.3 (main already took 1.2.2 for the 1.0 compatibility mark).
• index.yaml and README.md: version 1.2.3. The README table was regenerated with tools/readme-packages-table.py.
• tools/release/packages.py check-bumps origin/main HEAD: OK.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Rqqt7UANHQ73A3Wsib6mkh

Summary by CodeRabbit

• Bug Fixes
  • Encounter notices now check room and member location IDs when determining which local and completion notices to send.
• Chores
  • Updated the listed sheet-charge package version to 1.2.3.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The sheet-charge package version changes to 1.2.3. Encounter join, add, leave, and end checks compare room object IDs when deciding which players receive local notices.

Changes

Sheet-charge release

Layer / File(s)	Summary
Encounter notices and release version sheet-charge/package.yaml, index.yaml, README.md	Encounter commands compare room object IDs for local notice checks. The package version changes to 1.2.3 in package metadata and listings.

Estimated code review effort: 2 (Simple) | ~8 minutes

Possibly related PRs

• SharpMUSH/SharpMUSH.Packages#22: Adds the sheet-charge encounter implementation that this PR updates.
• SharpMUSH/SharpMUSH.Packages#90: Adds the README package-table generator and CI check. This PR updates the sheet-charge version listed in index.yaml and the README.

Suggested reviewers: claude

Merge Risk: Minimal · up to 4bce7

The update aligns encounter notices with stored room IDs. No merge-blocking risk is evident from the supplied evidence.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title identifies the version and the change to compare encounter room object IDs.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Essentials
• Run ID: 9b7da27c-c8d6-4709-986a-9f7df9842c6a

Commits

Reviewing files that changed from the base of the PR and between b40a834 and 4bce77b.

Files selected for processing: 3

• README.md
• index.yaml
• sheet-charge/package.yaml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.