Repository navigation
Protect abbreviated login commands in local echo and history - #129
Merged
HarryCordewener merged 1 commit intoNov 11, 2026
Merged
HarryCordewener merged 1 commit into
HarryCordewener merged 1 commit into
Conversation
Treat nonempty prefixes of connect as login commands when a name and password are supplied. Reuse the merged credential filtering for local echo, transcripts and command history, including command stacks.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
HarryCordewener
approved these changes
Nov 11, 2026
Member
|
Many thanks @nickrobnett! |
Contributor
Author
|
Happy to contribute. I really love the very simple idea of a prose window for playing a MUSH/MUX and have been enjoying using it and finding more and more cool features. Thanks for building it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abbreviated login commands such as
con name passwordandc name passwordbypass the credential detector, allowing passwords into local echo, transcripts and command history.Recognize every nonempty prefix of
connect, matching PennMUSH's login parser. Username-only forms such ascon guestremain ordinary input. The existing shared detector applies this protection to direct input and accepted or refused command stacks.Follow-up to #125 and #128... Found this when I was looking at the command stacking thing, just a gap from my original fix. Includes regression coverage for detection, local echo, transcripts, history recall and search, plus a changelog entry.
Validation: all 1,772 core tests and 3,043 terminal-client tests passed on Windows. I also tested abbreviated login commands in the earlier Windows build.