Skip to content

[E2E][Bug] fix flaky E2E order confirmation detection #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kieran-osgood-shopify wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Draft

[E2E][Bug] fix flaky E2E order confirmation detection #764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/tests/shared/checkout-guest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ env:
CARD_SECURITY_CODE: "123"
CARD_HOLDER_NAME: "Maestro Shopify"

# Accepted successful checkout states for this smoke test.
POST_SUBMIT_RESULT_PATTERN: ".*(Thank you|Your order|Order confirmed|confirmation).*"
# Require a complete confirmation heading so payment-page copy cannot satisfy this wait.
POST_SUBMIT_RESULT_PATTERN: "^(Thank you(, .+)?!?|Your order is confirmed|Order confirmed|Order confirmation)$"
---
- runFlow: ../../flows/app/bootstrap-cart-from-link.yaml
- runFlow: ../../flows/checkout/present.yaml
Expand Down
4 changes: 2 additions & 2 deletions e2e/tests/shared/checkout-hardcoded-buyer-identity.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ env:
CARD_SECURITY_CODE: "123"
CARD_HOLDER_NAME: "Evelyn Hartley"

# Accepted successful checkout states for this smoke test.
POST_SUBMIT_RESULT_PATTERN: ".*(Thank you|Your order|Order confirmed|confirmation).*"
# Require a complete confirmation heading so payment-page copy cannot satisfy this wait.
POST_SUBMIT_RESULT_PATTERN: "^(Thank you(, .+)?!?|Your order is confirmed|Order confirmed|Order confirmation)$"
---
- runFlow: ../../flows/app/bootstrap-cart-from-link.yaml
- runFlow: ../../flows/checkout/present.yaml
Expand Down
Loading