Skip to content

WIP: Consolidate Bitrise E2E and iOS status checks - #793

Open
kieran-osgood-shopify wants to merge 1 commit into
mainfrom
bitrise-link-status-check
Open

kieran-osgood-shopify wants to merge 1 commit into
mainfrom
bitrise-link-status-check

Conversation

@kieran-osgood-shopify

Copy link
Copy Markdown
Contributor

What changes are you making?

WIP — opened to verify the live Bitrise comments and status checks. Please do not review yet.

Make each Bitrise pipeline's native check reflect the evaluated results, rather than showing a green pipeline beside a failed custom check.

  • Publish the E2E and iOS CI reports before exiting with failure for failed or missing expected results.
  • Retain only ci/bitrise/e2e/pr and ci/bitrise/ci-ios/pr; stop creating the duplicate Checkout Kit E2E and Checkout Kit iOS checks.
  • Keep the existing E2E sticky comment and add a separate iOS CI sticky comment, sharing the existing create/update logic without allowing the pipelines to overwrite each other.
  • Include pipeline links on success and failure, preserving BrowserStack evidence and Tophat install links.
  • Preserve parallel result collection and iOS selection-aware evaluation. Manual builds evaluate results without requiring GitHub publication.

Both native checks are already required, so E2E assertion failures will now block merging. Their check names and branch rules are unchanged.

Local verification: all 345 Ruby tests pass with the pinned Ruby, and the Bitrise configuration validates.

How to test

GIVEN this PR is open and not a draft, so both Bitrise pipelines are triggered

WHEN the pipelines finish and the reviewer opens the PR's Checks and Conversation tabs

THEN Bitrise exposes only ci/bitrise/e2e/pr and ci/bitrise/ci-ios/pr, with separate E2E and iOS CI comments linking to their corresponding pipelines


GIVEN a temporary test branch contains these reporting changes and selects E2E coverage

WHEN the reviewer temporarily makes one selected E2E assertion fail, pushes the branch, and waits for all parallel runs and e2e-report to finish

THEN the E2E comment contains all collected results, failure evidence, install links for produced targets, and a pipeline link; e2e-report and the native E2E check fail. Previously, the native pipeline check stayed green despite the failed test.


GIVEN a temporary test branch contains these reporting changes and selects the Swift package tests

WHEN the reviewer temporarily adds a failing assertion to a Swift unit test, pushes the branch, and waits for ci-ios-report

THEN the iOS CI comment names the failed job, distinguishes deliberately unselected jobs, and links to the pipeline; the report and native iOS check fail without creating a second custom check


GIVEN a PR already has both reporting comments from a completed run

WHEN the reviewer reruns both pipelines for that PR

THEN each existing comment updates in place without overwriting the other pipeline's summary or creating a duplicate comment

Assisted-By: devx/b225c0cc-b463-4080-87ab-6a10147f792f
@kieran-osgood-shopify
kieran-osgood-shopify requested a review from a team as a code owner September 18, 2026 10:11
@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Sep 18, 2026
@bitrise

bitrise Bot commented Sep 18, 2026

Copy link
Copy Markdown

Checkout Kit iOS

Status Job Outcome
swift-package-tests passed
swift-samples passed
react-native-build-ios passed
react-native-test-ios passed

Pipeline build

@bitrise

bitrise Bot commented Sep 18, 2026

Copy link
Copy Markdown

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
React Native Install with Tophat
Swift Install with Tophat
Kotlin Install with Tophat

Checkout Kit E2E results

Status Tags Target Platform OS version tag Device
launch, checkout-presentation, checkout-completion, buyer-identity react-native ios latest iPhone 15
iOS 27 Beta
launch, checkout-presentation, checkout-completion, buyer-identity react-native android latest Google Pixel 9
Android 17.0
launch, checkout-presentation, checkout-completion, buyer-identity, preload kotlin android latest Google Pixel 9
Android 17.0
launch, checkout-presentation, checkout-completion, buyer-identity, preload swift ios latest iPhone 15
iOS 27 Beta

Failures

Caution

If you believe an assertion is flaky, please raise a ticket in the #checkout-kit-devs channel so it can be addressed.

BrowserStack artifacts require BrowserStack access. Sign in to BrowserStack App Automate before opening artifact links.

iOS — react-native

Test Status Artifacts
./tests/shared/checkout-guest BrowserStack · Video · Screenshot · Maestro commands · Maestro log

iOS — swift

Test Status Artifacts
./tests/shared/checkout-hardcoded-buyer-identity BrowserStack
./tests/shared/checkout-present-and-close BrowserStack
./tests/shared/native-preload-ready BrowserStack
./tests/shared/launch-smoke BrowserStack
./tests/shared/checkout-guest BrowserStack

Pipeline build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant