WIP: Consolidate Bitrise E2E and iOS status checks - #793
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
Assisted-By: devx/b225c0cc-b463-4080-87ab-6a10147f792f
Checkout Kit iOS
|
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
FailuresCaution If you believe an assertion is flaky, please raise a ticket in the #checkout-kit-devs channel so it can be addressed.
iOS — react-native
iOS — swift
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
WIP — opened to verify the live Bitrise comments and status checks. Please do not review yet.
Make each Bitrise pipeline's native check reflect the evaluated results, rather than showing a green pipeline beside a failed custom check.
ci/bitrise/e2e/prandci/bitrise/ci-ios/pr; stop creating the duplicateCheckout Kit E2EandCheckout Kit iOSchecks.Both native checks are already required, so E2E assertion failures will now block merging. Their check names and branch rules are unchanged.
Local verification: all 345 Ruby tests pass with the pinned Ruby, and the Bitrise configuration validates.
How to test
GIVEN this PR is open and not a draft, so both Bitrise pipelines are triggered
WHEN the pipelines finish and the reviewer opens the PR's Checks and Conversation tabs
THEN Bitrise exposes only
ci/bitrise/e2e/prandci/bitrise/ci-ios/pr, with separate E2E and iOS CI comments linking to their corresponding pipelinesGIVEN a temporary test branch contains these reporting changes and selects E2E coverage
WHEN the reviewer temporarily makes one selected E2E assertion fail, pushes the branch, and waits for all parallel runs and
e2e-reportto finishTHEN the E2E comment contains all collected results, failure evidence, install links for produced targets, and a pipeline link;
e2e-reportand the native E2E check fail. Previously, the native pipeline check stayed green despite the failed test.GIVEN a temporary test branch contains these reporting changes and selects the Swift package tests
WHEN the reviewer temporarily adds a failing assertion to a Swift unit test, pushes the branch, and waits for
ci-ios-reportTHEN the iOS CI comment names the failed job, distinguishes deliberately unselected jobs, and links to the pipeline; the report and native iOS check fail without creating a second custom check
GIVEN a PR already has both reporting comments from a completed run
WHEN the reviewer reruns both pipelines for that PR
THEN each existing comment updates in place without overwriting the other pipeline's summary or creating a duplicate comment