Conversation
This was referenced Sep 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review purpose
Define the merchant-facing TypeScript and custom-element contract without introducing wallet loading, network requests, or Portable Wallets behavior.
Stacked on
wallets/release-02-local-development.Changes
configure()patch semantics, including explicit clearing withundefinedgetCartfunction contract@shopify/checkout-kit/walletsCartIdentifiercartIdproperty-only so it is not reflected into markupContract note
The current API proposal gives an existing cart precedence over product inputs. Ticket #14699 currently says mixed inputs should be rejected. This PR follows the current proposal and intentionally does not close that ticket until its acceptance wording is reconciled.
The transport representation of
CartIdentifierremains unresolved. This PR does not normalize a full keyed Storefront Cart ID as the public contract.Non-goals
getCartRelated tickets
Primary: https://github.com/shop/issues-checkout/issues/14699
Related:
This PR defines API shapes used by the related tickets but does not claim their runtime acceptance criteria.
Validation
publint