Conversation
This was referenced Sep 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review purpose
Implement one deterministic custom-element lifecycle state machine against a Kit-internal fake adapter. This keeps public lifecycle semantics reviewable without a World, Core, or Portable Wallets runtime dependency.
Stacked on
wallets/release-03-merchant-contract.Changes
Non-goals
cartUpdated()forwardingRelated tickets
Primary: https://github.com/shop/issues-checkout/issues/14701
Related:
The fake-adapter ticket remains open until the adapter matches the final PW injection interface and all required development scenarios are represented.
Validation
publint