Conversation
This was referenced Sep 21, 2026
rsomlette
force-pushed
the
wallets/release-04-lifecycle
branch
from
September 24, 2026 01:34
b45b512 to
20a0880
Compare
rsomlette
force-pushed
the
wallets/release-05-cart-updates
branch
from
September 24, 2026 01:35
16d3739 to
be64b9c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review purpose
Add the existing-cart refresh signal as a separate, reviewable behavior instead of folding it into the general element lifecycle state machine.
Stacked on
wallets/release-04-lifecycle.Changes
cartUpdated()method for an active existing-cart flowNon-goals
Related ticket
Related: https://github.com/shop/issues-checkout/issues/14707
This PR satisfies the Kit-side queueing and forwarding contract against the fake adapter. It does not close the ticket until the real PW adapter consumes the signal and the active-attempt policy is verified.
Validation
publint