Repository navigation
Allow Swift hosts to handle navigation links - #852
Merged
Merged
Conversation
kiftio
added this pull request to stack #853
September 29, 2026 08:43
kiftio
force-pushed
the
swift-intercept-navigation-deep-links
branch
2 times, most recently
from
September 29, 2026 09:48
df7d454 to
9ffbd6e
Compare
kiftio
marked this pull request as ready for review
September 29, 2026 10:15
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
Base automatically changed from
android-intercept-navigation-deep-links
to
main
September 29, 2026 10:46
kiftio
force-pushed
the
swift-intercept-navigation-deep-links
branch
from
September 29, 2026 10:46
9ffbd6e to
5c1ec99
Compare
kieran-osgood-shopify
approved these changes
Oct 1, 2026
kiftio
force-pushed
the
swift-intercept-navigation-deep-links
branch
from
October 1, 2026 15:34
fb323d4 to
f40a3e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #851.
Swift had the same split behavior as Android: protocol
ec.window.open_requestcalls consultedonLinkClick, but a rawWKNavigationDelegatenavigation to a deep link opened throughUIApplicationdirectly.Apply the existing
linkActionProviderto intercepted deep-link navigation before the default external URL handler:openpreserves the current default behavior.handledlets the host own routing.cancelblocks the navigation.This keeps Swift and Android consistent and makes
onLinkClickgovern both protocol window-open requests and native WebView deep-link navigation.Tests
handledandcancelprevent the external URL handler from being invoked for a navigation deep link.platforms/swift/Scripts/xcode_run test ShopifyCheckoutKit-Package CheckoutWebViewTestsDiagnostics
Adds debug logging that distinguishes an intercepted raw navigation link from the host or SDK default-handling outcome.