Fix sealed intermediate parent - #543
Merged
Merged
Conversation
Sorbet doesn't support intermediate sealed parent classes yet sorbet/sorbet#8117. That makes Tapioca gem RBI generation crash without marking the intermediate class as sealed.
Morriar
approved these changes
Sep 17, 2026
GoodForOneFare
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorbet doesn't support intermediate parent sealed classes yet. Right now, we have
ImplicitSystem < System < Fault, but onlyFaultis marked as sealed.This works fine in execution, but it makes Tapioca gem RBI generation crash because it incorrectly detects that
Systemis not properly sealed due to other classes inheriting from it.The workaround, as specified in the issue, is to mark the intermediate ones as sealed too. I checked and this does fix the gem RBI generation.
This PR just adds the sealed annotation and bumps the patch version to cut a bugfix release.
@selviarora since you shipped some changes in main, can we make the next a patch release or does it have to be a minor?