Proto: Create dev stores from app dev - #8323
Draft
dmerand wants to merge 1 commit into
Draft
Conversation
Assisted-By: devx/847628e2-86d4-4bde-af0b-ba035ed61865
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/monorail.d.ts@@ -83,6 +83,7 @@ export interface Schemas {
cmd_dev_preview_url_opened?: Optional<boolean>;
cmd_dev_graphiql_opened?: Optional<boolean>;
cmd_dev_dev_preview_toggle_used?: Optional<boolean>;
+ cmd_dev_store_created?: Optional<boolean>;
cmd_create_app_template?: Optional<string>;
cmd_create_app_template_url?: Optional<string>;
cmd_deploy_flag_message_used?: Optional<boolean>;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app devcreate a development store inline from store selection, including store name and plan prompts.@shopify/organizations; keepstore create devbehavior and output modes.app dev, wait for the created store to appear, render success, and enforce transfer-disabled stores.Behavior
Create a new dev storewhen creation is available, including when one store exists; an empty list creates directly, and the choice remains during search.app dev --store <store-domain>guidance. Explicit and cacheddev_store_urlselection continues to work.Organization.devStoreCapReached. A capped organization hides creation; with no existing stores it receives a cap error and--storeguidance. Request or field errors fail open.Cap filtering depends on shop/world PR #944713 (open at d55a955954a7eedf03cad9ce2892c1c9c47ca5f7), which exposes
Organization.devStoreCapReached: Boolean!. Deploy that dependency before relying on cap enforcement; until then, the CLI's fail-open behavior keeps creation available.Verification
git diff --checkpnpm exec vitestandpnpm exec nxreport command not found). CI should run these checks after the World schema dependency is available.