Conversation
2 tasks
vctrchu
force-pushed
the
vctrchu/pos-intercept-bugbash
branch
from
September 22, 2026 00:13
46b9f8b to
f658efa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Provide a minimal, standalone POS intercept example for a temporary bug bash. This draft is for review and testing, not for merging the temporary template into
main.Related SDK changes: Shopify/ui-extensions#4713 and Shopify/ui-extensions#4714.
Solution
pos-intercept/and an opt-intemplates.pos-intercept.jsoncatalog exposingpos_intercept. Leave the publictemplates.jsonand existing POS templates unchanged.ERRORat$.cartfor a nonempty cart withoutexample_cart_reviewed="true".pos.cart.validations.resolution.render. The target registersshopify.resolution.onSave; Shopify-owned Save/Next/Done waits for the handler to persistexample_cart_reviewed, confirm the cart signal, and return before POS revalidates.2026-10, SDK2026.10.0-rc.13, Preact, and offline support.Local verification
.jsxmodule paths, paired targets, locales, catalog, and exact SDK pin.shopify app build --skip-dependencies-installationplustsc --noEmit -p extensions/pos-onsave-cart/tsconfig.jsonin a disposable app.onSaveregistration, no write before POS save, awaited property persistence, signal-confirmed revalidation, and absent or rejected writes that keep the finding active.Cannot find a valid organization. Real POS behavior remains unverified and requires an approved app in a preview-enabled POS environment.Generate for the internal bug bash
Run these commands from your Shopify app root—the directory containing
shopify.app.toml. To create an app first, follow Build your first POS UI extension. Change--nameif you want a different extension name.What these commands do:
curl --fail --location … --output /tmp/…downloads this branch's temporary template catalog.--failstops on an HTTP error,--locationfollows redirects, and/tmpkeeps the temporary file outside the app.SHOPIFY_CLI_APP_TEMPLATES_JSON_PATH=… shopify app generate extension …uses that catalog for this invocation. The catalog registers the temporary template identifier and maps it to its Preact directory.--clone-urlsupplies the branch containing the actual template files; it does not register the identifier.--namecontrols the generated extension name, and--path "$PWD"adds it to the current Shopify app.The custom catalog replaces CLI's default template catalog only for this command.
Use Shopify CLI 4.8.0 or later; do not pass
--flavor. These branch URLs are only for the internal bug bash/developer preview. Deployment and runtime testing still require an approved app and preview-enabled POS environment.Checklist