Skip to content

Use Node 24 - #66

Open
patrick-mcdougle wants to merge 2 commits into
Shopify:mainfrom
rothy-s:node_upgrade
Open

Use Node 24#66
patrick-mcdougle wants to merge 2 commits into
Shopify:mainfrom
rothy-s:node_upgrade

Conversation

@patrick-mcdougle

Copy link
Copy Markdown

This github action is starting to throw warnings about using Node 20. This PR upgrades the action to use node 24 instead.

Node 20 is EOL in April of 2026.

I did a quick skim of node 20 vs node 24 and I don't think this action is going to be using any of the things that had breaking changes.

@patrick-mcdougle
patrick-mcdougle marked this pull request as draft July 20, 2026 16:09
@patrick-mcdougle
patrick-mcdougle marked this pull request as ready for review July 20, 2026 16:09
@patrick-mcdougle

Copy link
Copy Markdown
Author

I have signed the CLA!

@github-actions

Copy link
Copy Markdown

CLA: Unexpected error has occurred, please re-run the workflow.

We are sorry for the inconvenience, due to GitHub actions limitations this requires a manual intervention.

There are few ways to do it:

  • Create a new pull request with the same changes.
  • Push an empty commit to the branch.
  • Rebase the branch on top of the latest master might also help.

If the issue persists, please contact the maintainers of this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant