Add JSONMissingSection check - #1286
Merged
Merged
Conversation
lukeh-shopify
marked this pull request as draft
August 26, 2026 21:30
lukeh-shopify
marked this pull request as ready for review
August 26, 2026 21:55
graygilmore
approved these changes
Aug 26, 2026
lukeh-shopify
force-pushed
the
lh-json-missing-section-check
branch
from
August 26, 2026 23:28
ffc7433 to
54c5cc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Theme Check already validates block and section references (in liquid files), but nothing validates the section type references inside json files. A theme can pass theme check locally while referencing a section file that doesn't exist, and then fail server-side validation on upload/publish.
This adds a JSONMissingSection check so that error surfaces at lint time instead
What approach did you use?
sections/<type>.liquiddoesn't exist.📸