Port code from PowerSystemsInvestments.jl to IOM - #170
Open
jerrypotts wants to merge 7 commits into
Open
jerrypotts wants to merge 7 commits into
jerrypotts wants to merge 7 commits into
Conversation
Contributor
|
Performance Results This branch |
Member
Author
jd-lara
reviewed
Sep 23, 2026
| @@ -0,0 +1,137 @@ | |||
| struct InvestmentIntervals | |||
Member
There was a problem hiding this comment.
WE should be able to generalize this concept
Member
Author
There was a problem hiding this comment.
From our discussion earlier this week: Going to merge the direct port of the time mapping as is and then open up a new PR proposing a more generalized structure
jd-lara
reviewed
Sep 23, 2026
jerrypotts
marked this pull request as ready for review
October 1, 2026 18:31
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jd-lara
self-requested a review
October 4, 2026 22:28
jd-lara
reviewed
Oct 4, 2026
| @@ -0,0 +1,99 @@ | |||
| mutable struct InvestmentModelStore <: AbstractModelStore | |||
Member
There was a problem hiding this comment.
do we need a separate store or can we generalize?
jd-lara
reviewed
Oct 4, 2026
| return | ||
| end | ||
|
|
||
| function write_optimizer_stats!( |
Member
There was a problem hiding this comment.
Same here, can we reuse the exiting code
jd-lara
reviewed
Oct 4, 2026
jd-lara
left a comment
jd-lara
left a comment
Member
There was a problem hiding this comment.
I think there is still a lot of opportunities for code reuse with the decision model
jd-lara
force-pushed
the
jp/invest_integration
branch
from
October 6, 2026 05:21
e9e753e to
70490b5
Compare
jd-lara
force-pushed
the
jp/invest_integration
branch
from
October 6, 2026 05:24
70490b5 to
e1ee146
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.