Repository navigation
Read the control objective's integer through Int, not .value - #317
Merged
Merged
Conversation
`IS.@scoped_enum` now wraps `EnumX.@enumx`, so a scoped enum's type is `Name.Value` and its instances have no `.value` field. This call site came in with #312, alongside the EnumX move, so neither PR caught it. It throws a FieldError from `instantiate_network_model!`, failing every build that pins a transformer control: test_phase_control, test_tap_control and test_native_network_reductions are red on main on both Linux and Windows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two one-liners
mainneeds..valueon a scoped enum.IS.@scoped_enumnow wrapsEnumX.@enumx, so instances have no.valuefield._pin_transformer_controls!still reads one, throwing aFieldErrorfrominstantiate_network_model!on any build that pins a transformer control. It came in with #312, alongside the EnumX move, so neither PR caught it.mainis red on it:test_phase_control,test_tap_controlandtest_native_network_reductions, on both Linux and Windows. All three pass locally with the fix.The EnumX source pins. PSY #1804, PSB #225, PTDP #11, IOM #169, PNM #372 and PF #453 have all landed, so the
lk/enumxpins go back to psy6/main. Cherry-picked from #309, which carried it while that PR was the one needing it.🤖 Generated with Claude Code