Repository navigation
G-1 reserves; use IOM.ComponentPairKey; EnumX changes - #321
Closed
acostarelli wants to merge 22 commits into
Closed
acostarelli wants to merge 22 commits into
acostarelli wants to merge 22 commits into
Conversation
added 20 commits
September 17, 2026 17:36
…straint and slacks on flow
… slacks keys need to be reconsidered I think
…of reserves code; enumx
Closed
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved critical dependency, test, reserve-keying, and G-1 monitoring issues block approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 6
Open (9)
What changed in this PR
Ports G-1 security-constrained reserve modeling, migrates reserve indexing to IOM.ComponentPairKey, and updates related models and tests.
Changes:
- Adds post-contingency reserve deployment, balance, flow, and slack modeling.
- Updates reserve construction, aggregation, offers, and device integrations.
- Updates EnumX handling, dependencies, output persistence, and regression coverage.
| File | Changes | Final review findings |
|---|---|---|
test/test_static_injection_security_constrained_models.jl |
Adds G-1 regression coverage. | Critical (1): No-requirement test checks an absent container incorrectly. |
test/test_services_constructor.jl |
Updates reserve-container assertions. | — |
test/test_model_decision.jl |
Adapts reserve output discovery. | — |
test/test_device_reserve_offers.jl |
Reads typed reserve awards. | — |
test/Project.toml |
Updates test dependencies and sources. | Critical (3): Contributor-specific absolute path. Critical (3): Removed compatible remote source while PowerFlows tests remain enabled. |
test/includes.jl |
Changes test imports. | Critical (3): PFS import is disabled while dependent tests remain enabled. |
src/static_injector_models/thermal_generation.jl |
Updates offline reserve lookup. | — |
src/static_injector_models/hydro_generation.jl |
Updates reserve variable keys. | — |
src/services_models/services_constructor.jl |
Constructs security-constrained service models. | — |
src/services_models/security_constrained_injectors.jl |
Implements G-1 reserve modeling. | Critical (1): Modeled branch types are skipped due to an inverted condition. Moderate (2): Validation ignores the per-device filter_function. |
src/services_models/reserves.jl |
Migrates reserve aggregation and costs. | Critical (1): Participation constraints can collide without device-type keys. |
src/services_models/reserve_offers.jl |
Supports device-type offer keys. | — |
src/services_models/reserve_group.jl |
Aggregates pair-keyed reserve variables. | — |
src/PowerOperationsModels.jl |
Registers and exports G-1 APIs. | Moderate (3): Removes the existing HVDCDCControlConstraint export. |
src/operation/template_validation.jl |
Reorganizes outage validation. | — |
src/operation/decision_model.jl |
Changes system output persistence. | Moderate (3): Comments out the PSY.to_file persistence call. |
src/hybrid_system_models/hybrid_systems.jl |
Updates hybrid reserve keys. | — |
src/energy_storage_models/storage_models.jl |
Updates storage reserve keys. | — |
src/core/variables.jl |
Adds G-1 variables. | — |
src/core/formulations.jl |
Adds security-constrained reserve formulations. | Nit (1): Documentation inaccurately describes service attachment validation. |
src/core/expressions.jl |
Adds post-contingency expressions. | — |
src/core/constraints.jl |
Adds G-1 constraints. | Nit (1): Exported constraint retains an incomplete docstring. |
src/common_models/converter_control.jl |
Updates EnumX type signatures. | — |
src/common_models/add_to_expression.jl |
Updates reserve expression keys. | — |
Project.toml |
Updates package sources and dependencies. | Critical (3): Contributor-specific absolute path prevents clean checkout and CI instantiation. |
ext/PowerFlowsExt/pf_headroom.jl |
Updates EnumX bus typing. | — |
.claude/pom_port_plan.md |
Removes the porting plan. | — |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
acostarelli
commented
Sep 23, 2026
acostarelli
commented
Sep 23, 2026
acostarelli
commented
Sep 24, 2026
Member
|
@acostarelli we should close this and reopen with just the G-1 code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires Sienna-Platform/InfrastructureOptimizationModels.jl#171