Repository navigation
Preserve finalizer configurations when loading processing pipelines - #597
Open
leela-padala wants to merge 1 commit into
Open
leela-padala wants to merge 1 commit into
leela-padala wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a processing pipeline with finalizers mutates the caller's configuration by removing
typeand policy-related keys. Reusing that dictionary for a second pipeline then fails, which affects callers building multiple backend pipelines from a shared parsed configuration.Minimal reproduction on current main (
54e4077):Copy each finalizer entry before parsing it, both in
ProcessingPipeline.from_dictandNestedFinalizer.from_dict. The existing policy-key stripping and policy enforcement still apply to the local copy. No public API or output format changes.Regression tests cover repeated loading and unchanged input for concat, inline templates, nested/recursive finalizers, direct nested-finalizer construction, and rejected template-policy overrides. The original top-level test and four nested cases failed before their respective fixes.
Validation:
pytest -q -m 'not online').black --check .: passed;mypy: no issues in 70 source files;git diff --check: passed.AI assistance: Codex helped investigate, implement, and test this fix.