This repository was archived by the owner on Sep 10, 2026. It is now read-only.
Link GitHub repository with an icon (fleet policy #91) - #33
Merged
Conversation
Reusing one anchor inline in both SiteHeader and Changelog pushed the lizard-measured length of Changelog past the checked-in ceiling (a lizard TSX-parsing quirk triggered by a hyphenated JSX attribute like aria-label on a second multi-attribute anchor in that function). Extracting RepoLink removes the duplication and keeps both call sites to a single attribute, resolving the regression. Refs sass-maker/saas-maker#91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fleet policy sass-maker/saas-maker#91: public sites must link to their own GitHub repo with an icon, never visible text like "GitHub"/"Source".
This is a single-page-ish Vite/React app with three build entries (index.html/game, changelog.html, faq.html) sharing one src/App.tsx. Only the changelog page had an existing repo link ("Source"); the main game page and the FAQ page had none.
Files changed:
GithubIconSVG component (lucide-react, already used for the Settings icon here, does not ship a GitHub/brand icon in the installed version, so an inline SVG per the spec was used and shared via one component to avoid duplication). Added an icon-only GitHub link to the sharedSiteHeadernav (next to FAQ/Changelog - covers the main game page, which previously had no repo link at all) and replaced the changelog page's existing "Source" text link with the same icon in place.All links point to https://github.com/Significant-Hobbies/chess with target="_blank" rel="noopener noreferrer" aria-label/title="GitHub repository".
Left unchanged (out of scope): the adjacent "Roadmap" link (changelog page) points to /issues, not the repo itself, so the repo-link icon rule doesn't apply to it.
Verification: