Link GitHub repository with an icon (fleet policy #91) - #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the visible "Source" text link in the landing footer with an icon-only GitHub link, per fleet policy sass-maker/saas-maker#91 (no visible GitHub/Source text on public sites).
Changes
landing-astro/src/components/SiteFooter.astro: the repo link (https://github.com/Significant-Hobbies/rolepatch) now renders as an inline SVG GitHub mark (aria-label/title="GitHub repository", opens in new tab) instead of the text "Source". Position, surrounding nav classes, and hover styling are unchanged./issues) is untouched — it isn't a "GitHub"/"Source" text link to the repo itself.Verification
pnpm install --frozen-lockfilecd landing-astro && pnpm run build— astro build succeeds, 4 pages generateddist/index.htmlcontains the icon-only anchor with correct href/aria-label and no visible textpnpm lint(biome, pre-commit hook) — 296 files checked, clean