Repository navigation
Make production smoke CLI run from paths with spaces - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The direct-execution guard compared Node's percent-encoded
import.meta.urlwith a rawfile://string built fromprocess.argv[1]. In worktree paths containing spaces,pnpm smoke:prodcould exit 0 without running any checks.The guard now compares against
pathToFileURL(process.argv[1]).href. A child-process regression copies the CLI into a path containing spaces, runs it against a local HTTP fixture, verifies all six public check results print, and confirms one 503 produces a nonzero exit. It sends no production requests and uses no session cookie.Validation: the new regression passed after reproducing the baseline silent exit; the full
production-smoke.test.tspassed (5/5);pnpm run typecheckpassed; changed-file Biome passed; the push hook's full-repository Biome check passed (327 files). Exact PR CI is pending.Tracks #6.