Fix error resubscribe

[KyuminAhn]

• Fix re-subscription timeout after hub replacement
• fingerprints.yml: add matterManufacturer entries (AIHomeKit 0x1241/0x804E, BritzyHub 0x1436/0x800C) and tag generic device types with vendorId

Check all that apply

Type of Change

• WWST Certification Request
  • If this is your first time contributing code:
    • I have reviewed the README.md file
    • I have reviewed the CODE_OF_CONDUCT.md file
    • I have signed the CLA
  • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
• Bug fix
• New feature
• Refactor

Checklist

• I have performed a self-review of my code
• I have commented my code in hard-to-understand areas
• I have verified my changes by testing with a device or have communicated a plan for testing
• I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

[github-actions]

Duplicate profile check: Passed - no duplicate profiles detected.

[github-actions]

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/WY2WkmLB7x2r

[github-actions]

Test Results

   73 files  ±0    538 suites  ±0   0s ⏱️ ±0s
3 192 tests ±0  3 192 ✅ ±0  0 💤 ±0  0 ❌ ±0 
5 193 runs  ±0  5 193 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0805dfe. ± Comparison against base commit 4a06ba8.

♻️ This comment has been updated with latest results.

[github-actions]

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 0805dfe

[ctowns]

I wonder if the issue is that there was no subscription being sent my the bridge device if this bridge_init function was not previously populated?

@DongHoon-Ryu could you check if just removing this function causes the issue to occur again during hub replace? And then if adding it back fixes the issue?

The reason I am more suspicious of this is because the other subscribe logic above is very similar to what already exists in the subscribe function, so I'm not sure yet how that is providing a change in functionality.

[KyuminAhn]

I ran the test you asked for.
With bridge_init removed and the rest of the changes left in place, after a hub replace:

• Toggling on/off from the device list screen in the SmartThings app still works.
• But opening an individual device's detail view and toggling on/off fails with a connection error
• ("There was a problem with the connection" - you can see the pic attached

).

[hcarter-775]

HI @KyuminAhn, would you mind providing hub logs around the time of the error you are seeing in the app? Thank you

[DongHoon-Ryu]

@hcarter-775 Please check MTR-1083. If additional logs are needed, please leave a comment on the ticket.

[ctowns]

Thank you for testing this!

Based on this, I believe this shows that the part of these changes that were fixing this issue are isolated to this file. Therefore, to move forward, I propose that we keep the changes in these files:

• drivers/SinuxSoft/britzyhub/src/init.lua
• drivers/SinuxSoft/britzyhub/fingerprints.yml
• drivers/SinuxSoft/britzyhub/profiles/matter-bridge.yml

But I do not believe the changes in the sub drivers are neccessary, so we could remove the changes in the remaining files:

• drivers/SinuxSoft/britzyhub/src/elevator/init.lua
• drivers/SinuxSoft/britzyhub/src/gas-valve/init.lua
• drivers/SinuxSoft/britzyhub/src/vent/init.lua
• drivers/SinuxSoft/britzyhub/src/utils.lua

My comment on the ticket has more detail. I believe if we adjust the changes as I have mentioned above and re-test, we should see that the subscription is now handled properly without the need to add additional sub driver changes. Please let me know if you have any questions!

[DongHoon-Ryu]

@ctowns Problems continue to occur when only the files you suggested are modified. Please refer to the comments in MTR-1083.