WWSTCERT-12629 - updates heiman smoke sensor device profiles - #3110
Open
KKlimczukS wants to merge 5 commits into
Open
WWSTCERT-12629 - updates heiman smoke sensor device profiles#3110KKlimczukS wants to merge 5 commits into
KKlimczukS wants to merge 5 commits into
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 73 files 540 suites 0s ⏱️ Results for commit 8c4bb16. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a033c3f |
ctowns
reviewed
Jul 10, 2026
| @@ -0,0 +1,16 @@ | |||
| name: smoke-heiman | |||
Contributor
There was a problem hiding this comment.
Could we update this name to something like smoke-no-sensitivity in case it is used by other devices in the future. In general, we should avoid including manufacturer names in profiles so they can be used elsewhere as needed.
|
matter-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8c4bb16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Heiman has asked to update their device profiles because smoke sensors don't support this device preference:
certifiedpreferences.smokeSensorSensitivitySummary of Completed Tests