Skip to content

Add shinasystem's SiHAS Smoke Detector for wwst - #3134

Merged
cbaumler merged 3 commits into
SmartThingsCommunity:mainfrom
shinasys:FAM300Z
Jul 28, 2026
Merged

Add shinasystem's SiHAS Smoke Detector for wwst#3134
cbaumler merged 3 commits into
SmartThingsCommunity:mainfrom
shinasys:FAM300Z

Conversation

@shinasys

@shinasys shinasys commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

  • Test Suite
    Test session: 63AMD36SOL

@github-actions

github-actions Bot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Channel deleted.

@github-actions

github-actions Bot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

   73 files    540 suites   0s ⏱️
3 241 tests 3 241 ✅ 0 💤 0 ❌
5 233 runs  5 233 ✅ 0 💤 0 ❌

Results for commit 1c3f5e2.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown

File Coverage
All files 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/frient/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/shinasystem/can_handle.lua 75% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/aqara/init.lua 97% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 113b912

cjswedes
cjswedes reviewed Jul 21, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/shinasystem/init.lua
cluster = IASZone.ID,
attribute = IASZone.attributes.ZoneStatus.ID,
minimum_interval = 1,
maximum_interval = 1200, -- Zigbee poll interval is 600s. Added because the default reporting maximum_interval (180s) must be greater than 600s.

@cjswedes cjswedes Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the reasoning here? Is this being done to conserve battery, or for some other reason?

@shinasys shinasys Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The main reason is to reduce battery consumption.

Additionally, it was set up to prevent the device from unnecessarily going offline. Since the device wakes up every 600 seconds after completing the pairing process, the interval needs to be greater than 600 seconds. Therefore, an appropriate value equal to twice that duration (1,200s) was applied.

@cjswedes cjswedes Jul 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The battery life reason makes sense and justifies the subdriver.

I do want to mention that the way we detect zigbee devices online/offline (new in 0.61 hub FW) is based on the configured reporting interval for a device. There is a default period that is used, but as soon as the device is configured (which happens right after pairing), the time it takes to detect a device as offline is ~3x the shortest configured max attribute reporting interval.

@shinasys shinasys Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing the info!

hcarter-775
hcarter-775 reviewed Jul 27, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/shinasystem/can_handle.lua Outdated
@@ -0,0 +1,11 @@
-- Copyright 2025 SmartThings, Inc.

@hcarter-775 hcarter-775 Jul 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update year

@shinasys shinasys Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in the latest commit!

Comment thread drivers/SmartThings/zigbee-smoke-detector/src/shinasystem/init.lua Outdated
@@ -0,0 +1,34 @@
-- Copyright 2022 SmartThings, Inc.

@hcarter-775 hcarter-775 Jul 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update year

@shinasys shinasys Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in the latest commit!

@shinasys shinasys Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in the latest commit!

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

zigbee-smoke-detector_coverage.xml

File Coverage
All files 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/aqara/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/shinasystem/can_handle.lua 75% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/frient/init.lua 98% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 1c3f5e2

@cbaumler
cbaumler merged commit fdd699a into SmartThingsCommunity:main Jul 28, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hcarter-775 hcarter-775 hcarter-775 left review comments
@cjswedes cjswedes cjswedes approved these changes
@aleclorimer aleclorimer aleclorimer approved these changes
@nand-nor nand-nor Awaiting requested review from nand-nor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shinasys @cjswedes @hcarter-775 @aleclorimer @cbaumler