GHA: Validate Fingerprints - #3140
Open
hcarter-775 wants to merge 2 commits into
Open
Conversation
hcarter-775
requested review from
NoahCornell,
aleclorimer,
cjswedes,
ctowns and
tpmanley
July 22, 2026 19:29
Test Results 73 files 540 suites 0s ⏱️ Results for commit fddafb8. ♻️ This comment has been updated with latest results. |
|
zigbee-water-leak-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against fddafb8 |
cjswedes
reviewed
Jul 27, 2026
| HEX_FIELDS = {'vendorId', 'productId', 'productType', 'manufacturerId'} | ||
|
|
||
| # YAML characters that force quoting when present in an unquoted scalar. | ||
| _YAML_SPECIAL_RE = re.compile(r'[:{}\[\],&#*?|<>=!%@`]') |
Contributor
There was a problem hiding this comment.
The _* prefix is sort of weird here; usually means something internal, but being a script it is all internal...
| deviceProfileName: humidity-temp-battery-aqara | ||
| - id: "eZEX/E282-KR0B0Z1-HA" | ||
| deviceLabel: eZEX Multipurpose Sensor | ||
| manufacturer: eZEX |
Contributor
There was a problem hiding this comment.
Only one of the manufacturer or model must be present...so I think this was intentional, and this change is now limiting the devices that will match the fingerprint.
Contributor
There was a problem hiding this comment.
Sometimes either a manufacturer or a model alone is enough for the matching, and sometimes it is desired to have that be a wildcard.
Contributor
There was a problem hiding this comment.
I think this is intentional as well, both here and in the other fingerprints that were updated. Some devices do not populate the ManufacturerName attribute and in those cases we did not include the manufacturer in the fingerprint.
Contributor
Author
There was a problem hiding this comment.
Hmmm, ok good to know. I was not sure, so I can just remove this check. In Matter we need both vid and pid, so I incorrectly assumed there was a similar requirement elsewhere.
Contributor
Author
There was a problem hiding this comment.
It seems like, as far as all examples we actually have, the only field ever unpopulated is Manufacturer, never model. Anyone know anything about that? Should model always be expected? Seems like yes from an initial thought
Contributor
There was a problem hiding this comment.
At least one must be present.
Contributor
There was a problem hiding this comment.
The requirement enforced by driver API is that either or both manufacturer or model need to be specified so I think that's what we should require here as well
Contributor
Author
There was a problem hiding this comment.
Thank guys. This alteration to the requirements has been applied
hcarter-775
force-pushed
the
validate/fingerprints-yml-gha
branch
from
July 28, 2026 15:49
92e640d to
fddafb8
Compare
|
Invitation URL: |
|
zigbee-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against fddafb8 |
|
zigbee-smoke-detector_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against fddafb8 |
|
zwave-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against fddafb8 |
|
zigbee-button_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against fddafb8 |
|
zwave-virtual-momentary-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against fddafb8 |
|
zwave-window-treatment_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against fddafb8 |
|
zwave-garage-door-opener_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against fddafb8 |
|
matter-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against fddafb8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Validate altered fingerprints via GHA. All associated fingerprints changes are an output of this script.
Summary of Completed Tests
Tested locally. See file alterations for output results